Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Python 3.12 in LangFair #126

Merged
merged 4 commits into from
Feb 18, 2025

Conversation

kmadan
Copy link

@kmadan kmadan commented Feb 15, 2025

📌 Description

This PR adds official support for Python 3.12 by:

  • Updating pyproject.toml to allow Python 3.12 (python = ">=3.9,<3.13").
  • Regenerating poetry.lock to reflect updated dependencies.
  • Running the full test suite (pytest tests/) to confirm compatibility.

CC: @langfair-maintainers


📌 Contributor License Agreement

📌 Tests

  • No new tests required (Existing test suite was sufficient)
  • New tests added
  • Existing tests adjusted

📌 Explanation:

  • No code logic was changed, so no new tests were required.
  • Ran the full test suite, and all 30 tests passed ✅.

📌 Documentation

  • No documentation changes needed
  • README updated
  • API docs added or updated
  • Example notebook added or updated

📌 Explanation:
Since this PR only updates Python version support, no documentation updates were needed.


📌 Screenshots

📌 Test Results Output:

================================== 30 passed, 6 warnings in 460.10s (0:07:40) ==================================

@dylanbouchard dylanbouchard changed the base branch from main to develop February 16, 2025 18:22
@dylanbouchard dylanbouchard self-requested a review February 16, 2025 18:23
Copy link
Collaborator

@dylanbouchard dylanbouchard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 @kmadan, thank you very much for creating this PR. Very excited to include support for Python 3.12 in LangFair!

Can you please make the following changes:

  • remove changes to .gitignore
  • remove tests/test_langfair312.py
  • update .github/workflows/ci.yaml to include 3.12 in tests?

Afterward, I will run tests and approve. Thank you!

.gitignore Outdated
@@ -1,3 +1,5 @@
langfair-mantric/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove these changes to the .gitignore for this PR

@@ -0,0 +1,43 @@
import langfair
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell, this file is not needed. Can you please remove it?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is not required. 👍

@dylanbouchard dylanbouchard self-requested a review February 17, 2025 18:36
@kmadan
Copy link
Author

kmadan commented Feb 17, 2025

👋 @dylanbouchard thank you for the helpful feedback and for taking the time to review my PR! I've removed the changes to .gitignore, deleted tests/test_langfair312.py, and updated .github/workflows/ci.yaml to include Python 3.12 in the test matrix. The tests are currently in progress, and I appreciate your patience. Please let me know if there’s anything else needed. Thanks again for your support!

@dylanbouchard
Copy link
Collaborator

Looks good!

@dylanbouchard dylanbouchard merged commit 5eaeb02 into cvs-health:develop Feb 18, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants