-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for Python 3.12 in LangFair #126
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 @kmadan, thank you very much for creating this PR. Very excited to include support for Python 3.12 in LangFair!
Can you please make the following changes:
- remove changes to .gitignore
- remove tests/test_langfair312.py
- update .github/workflows/ci.yaml to include 3.12 in tests?
Afterward, I will run tests and approve. Thank you!
.gitignore
Outdated
@@ -1,3 +1,5 @@ | |||
langfair-mantric/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can remove these changes to the .gitignore for this PR
tests/test_langfair312.py
Outdated
@@ -0,0 +1,43 @@ | |||
import langfair |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can tell, this file is not needed. Can you please remove it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is not required. 👍
👋 @dylanbouchard thank you for the helpful feedback and for taking the time to review my PR! I've removed the changes to .gitignore, deleted tests/test_langfair312.py, and updated .github/workflows/ci.yaml to include Python 3.12 in the test matrix. The tests are currently in progress, and I appreciate your patience. Please let me know if there’s anything else needed. Thanks again for your support! |
Looks good! |
📌 Description
This PR adds official support for Python 3.12 by:
pyproject.toml
to allow Python 3.12 (python = ">=3.9,<3.13"
).poetry.lock
to reflect updated dependencies.pytest tests/
) to confirm compatibility.CC: @langfair-maintainers
📌 Contributor License Agreement
📌 Tests
📌 Explanation:
📌 Documentation
📌 Explanation:
Since this PR only updates Python version support, no documentation updates were needed.
📌 Screenshots
📌 Test Results Output: