“Client not configured” error

[jnv]

Somehow some specs are failing on top-level class which should delegate calls to a client instance: https://travis-ci.org/cvut/kosapi_client.rb/jobs/53568760

This is happening even with isolated classes like HttpClient – something is trying to call to_str on KOSapiClient. Frankly, I have no idea what's going on.

[jnv]

I see this is addressed in PR #10, but I wouldn't accept this hack.
It makes no sense that the code suddenly stopped working.

[DraCzris]

IMHO it is related to rspec mocking (instance_doble). Because when I've tried to swap instance doubles with real object instances it works.

Maybe it is linked to mauricio/rspec-mocks@80c740e

[jnv]

Yep, it occured to me that it might be some metaprogramming mindfuck caused by the fact that KOSapiClient module acts both as a namespace and a delegator for a client.

[DraCzris]

In this exact situation, that is not caused by metaprogramming. The problem here is that the mocking service is invoking to_str method. Thats problem of rspec as in rspec/rspec-mocks#577.

I've come around with a solution, which is less "hackier" in 9cb112f of #10

[jnv]

Well, look at the date of that PR, this behaviour has been fixed in RSpec 3.0. Since we don't have a Gemfile.lock file, I guess this is some regression in newer RSpec (I run this on 3.2).

So the solutions are:

• Lock rspec-mocks dev dependency to an earlier version (in gemspec),
• introduce a workaround into the top-level module (which is fundamentally wrong because the module cannot be coerced into an equivalent string representation),
• remove implicit forwarding behaviour from the top-level module – I personally favour this option, because it removes complexity and nudges to a better practice (at a very slight price of inconvenience), however it is a breaking change.

[tszolar]

In 0439b5b I have refactored client lazy initalization to be more robust. Before this change an error was thrown right away when the client was initialized without supplying API credentials. Now the client only throws an error when an API request is made without credentials.

It should fix this issue in a clean way and it also prevents other possible problems in the future.

[jnv]

👍 Nice job, this is definitely an improvement though I'm still not a fan of the top-level stateful singleton KOSapiClient delegator.