Failure no longer shows description

[neclimdul]

Verification

• I have updated Composer to the most recent stable release (composer self-update)
• I have updated Composer Patches to the most recent stable release (composer update cweagans/composer-patches)
• I am using one of the supported PHP versions (8.0+)
• I have searched existing issues and discussions for my idea.

Is your feature request related to a problem?

In the 2.0 release the description isn't in the output making it more difficult to debug patch failures.

For example, previously patch failures would look something like:

  - Applying patches for drupal/core
    https://git.drupalcode.org/project/drupal/-/commit/dne.patch (really cool patch from next release)
   Could not apply patch! Skipping. The error was: Cannot apply patch https://git.drupalcode.org/project/drupal/-/commit/dne.patch

Its quite clear this was the "really cool patch"

But now they look like:

  - Patching drupal/core
      - Found cached patch at /mnt/ddev-global-cache/composer/patches/c0388b619228608ba69d8303e07789fb3762d41d58ba8aa26d53529ad498022a.patch

In Patches.php line 288:
                                                                                                                            
  No available patcher was able to apply patch https://git.drupalcode.org/project/drupal/-/commit/dne.patch to drupal/core  
                                                                                                                            

I often use this to reference the merge/issue or other relevant context so when you see the failure its obvious what failed, what it was used for, where to go to engage with fixing it, etc.

Now, unless its a local patch with a very descriptive file name, its much more difficult to diagnose requiring digging through the patches list.

Describe your proposed solution(s)

Add the description back some where in the patching or failure output so its clear what is being applied and failed.

Describe alternatives

Don't know what an alternative would be. This would just be restoring some useful context to developers.

Additional context

No response

[github-actions]

👋 Thanks for the idea! Please remember that this is an open source project - feature requests may or may not be implemented, and if they are, the timeline is unknown. If you need a guaranteed implementation or timeline, sponsorships are welcome!

[neclimdul]

I started to write a PR for this, it seems very doable as the Patch object in Patches::apply has the description available. However I wasn't sure if if should be part of the exception, in the debug message, or maybe something else?

It's technically available in the Downloader where the "Found cached patch" output is as well. While this would clarify what the hash'd value means, that seems maybe a weird place to put it and that is Verbose output so less obvious if its triggered say in a CI where you're not always showing verbose output.

[cweagans]

I think it probably makes sense to add this to the exception, but if it should go elsewhere instead (or in addition), that works too. I don't have a strong opinion on that.

[Berdir]

I ended up here looking for an issue about the "Found cached patch... ", if you have 20 patches you just see that repeated 20x with different hashes.

I think that message is not useful, I was going to suggest to make it a debug level but I'm also more than happy if we replace it with essentially what we had before, url + description.