Skip to content

feat(robot): navigation #1277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

feat(robot): navigation #1277

wants to merge 7 commits into from

Conversation

@OggyKUN
Copy link
Contributor

@OggyKUN OggyKUN commented Sep 3, 2024 •
edited by happylolonly
Loading

  • settings to robot
  • consistent navigation

#1225

@netlify
Copy link

netlify bot commented Sep 3, 2024 •
edited
Loading

✅ Deploy Preview for rebyc ready!

Name Link
🔨 Latest commit 6fdf0b4
🔍 Latest deploy log https://app.netlify.com/sites/rebyc/deploys/66d92be79930030008b0f6c1
😎 Deploy Preview https://deploy-preview-1277--rebyc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 3, 2024 •
edited
Loading

✅ Deploy Preview for cyb-xp ready!

Name Link
🔨 Latest commit 6fdf0b4
🔍 Latest deploy log https://app.netlify.com/sites/cyb-xp/deploys/66d92be7e69ac10008c951aa
😎 Deploy Preview https://deploy-preview-1277--cyb-xp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ghost
Copy link

ghost commented Sep 3, 2024 •
edited by ghost
Loading

Auto Wiki will use this pull request to update the cybercongress/cyb-ts article.

Here's a preview of how the article will be updated when this pull request is merged:

SectionAction
No sections need to be updated

View the latest preview

@OggyKUN OggyKUN requested a review from happylolonly September 3, 2024 14:00
@OggyKUN OggyKUN self-assigned this Sep 3, 2024
happylolonly
happylolonly requested changes Sep 4, 2024
View reviewed changes
Copy link
Collaborator

@happylolonly happylolonly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crashing for zero user

@cyborgshead
Copy link
Contributor

cyborgshead commented Sep 4, 2024

@OggyKUN same issue as @happylolonly found - crashing with empty user

@happylolonly happylolonly assigned happylolonly and unassigned OggyKUN Sep 5, 2024
@happylolonly happylolonly marked this pull request as draft September 5, 2024 03:51
@happylolonly happylolonly changed the title feat(settings): transferred settings into robot menu feat(robot): navigation Sep 5, 2024
mastercyb
mastercyb requested changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@mastercyb mastercyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • embed content of settings in viewport of robot
  • zero user must be handled the same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mastercyb mastercyb mastercyb requested changes

@happylolonly happylolonly happylolonly requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@happylolonly happylolonly

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@OggyKUN @cyborgshead @mastercyb @happylolonly