Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

track installed files #149

Open
oliver-sanders opened this issue Jul 5, 2022 · 2 comments
Open

track installed files #149

oliver-sanders opened this issue Jul 5, 2022 · 2 comments
Milestone

Comments

@oliver-sanders
Copy link
Member

oliver-sanders commented Jul 5, 2022

Rose fileinstall adds things into the run directory. If these things are not placed in work/ or share/ then they will be overwritten and subsequently reinstalled by cylc reinstall. This is ok but inefficient - #152.

Cylc-Rose should maintain a list of all of the stuff it has installed and provide that list to cylc reinstall where it can be merged in with the contents of the .cylcignore file (anything listed in cylcignore will be excluded from reinstall).

Pull requests welcome!

@oliver-sanders oliver-sanders added this to the 1.x milestone Jul 5, 2022
@wxtim wxtim self-assigned this Jul 22, 2022
@wxtim
Copy link
Member

wxtim commented Jul 22, 2022

Is that safe? What if someone is trying to update the files which Rose is installing?

@oliver-sanders
Copy link
Member Author

Sorry, this issue was a little rushed.

The pressing aspect of this issue is cylc install --dry-run which currently shows all files installed by Rose as deleted. This is due to #152.

So the main problem here is stopping cylc install --dry-run from showing these files as deleted, not conveying any additional changes that metomi-rose would make.

However, if metomi-rose does/can support a dry-run mode of it's own then that could be used to generate this list dynamically which would be great! #152 would offer

@wxtim wxtim removed their assignment Aug 31, 2022
@oliver-sanders oliver-sanders modified the milestones: 1.2.0, 1.3.0 Dec 7, 2022
@oliver-sanders oliver-sanders modified the milestones: 1.3.0, 1.4.0 Jul 17, 2023
@oliver-sanders oliver-sanders modified the milestones: 1.4.0, 1.5.0 Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants