Disable pytest-asyncio

Seems to conflict with pytest-tornasync.
And pytest-tornasync should be capable of running the async tests itself anyway

Author: MetRonnie

cylc/uiserver/tests/conftest.py

@@ -72,27 +72,6 @@ def async_client():
     return AsyncClientFixture()
 
 
-@pytest.fixture(scope='module')
-def event_loop():
-    """This fixture defines the event loop used for each test.
-
-    The overrides the default function-scope for this pytest-asyncio fixture,
-    allowing module scoped async fixtures. It means all tests in a module
-    will run in the same event loop. This is fine, it's actually an
-    efficiency win but also something to be aware of.
-
-    See: https://github.com/pytest-dev/pytest-asyncio/issues/171
-    """
-    loop = asyncio.get_event_loop_policy().new_event_loop()
-    yield loop
-    # gracefully exit async generators
-    loop.run_until_complete(loop.shutdown_asyncgens())
-    # cancel any tasks still running in this event loop
-    for task in asyncio.all_tasks(loop):
-        task.cancel()
-    loop.close()
-
-
 @pytest.fixture
 def workflows_manager() -> WorkflowsManager:
     return WorkflowsManager(None, logging.getLogger('cylc'))

cylc/uiserver/tests/test_data_store_mgr.py

@@ -29,7 +29,6 @@
 from .conftest import AsyncClientFixture
 
 
-@pytest.mark.asyncio
 async def test_entire_workflow_update(
     async_client: AsyncClientFixture,
     data_store_mgr: DataStoreMgr,
@@ -61,7 +60,6 @@ async def test_entire_workflow_update(
     assert entire_workflow.workflow.id == w_id_data['workflow'].id
 
 
-@pytest.mark.asyncio
 async def test_entire_workflow_update_ignores_timeout_message(
     async_client: AsyncClientFixture,
     data_store_mgr: DataStoreMgr
@@ -89,7 +87,6 @@ async def test_entire_workflow_update_ignores_timeout_message(
     assert w_id not in data_store_mgr.data
 
 
-@pytest.mark.asyncio
 async def test_entire_workflow_update_gather_error(
     async_client: AsyncClientFixture,
     data_store_mgr: DataStoreMgr,
@@ -128,7 +125,6 @@ async def test_entire_workflow_update_gather_error(
     assert caplog.records[0].exc_info[0] == error_type
 
 
-@pytest.mark.asyncio
 async def test_register_workflow(
     data_store_mgr: DataStoreMgr
 ):
@@ -141,7 +137,6 @@ async def test_register_workflow(
     assert w_id in data_store_mgr.delta_queues
 
 
-@pytest.mark.asyncio
 async def test_update_contact_no_contact_data(
     data_store_mgr: DataStoreMgr
 ):
@@ -154,7 +149,6 @@ async def test_update_contact_no_contact_data(
     assert api_version == data_store_mgr.data[w_id]['workflow'].api_version
 
 
-@pytest.mark.asyncio
 async def test_update_contact_with_contact_data(
     data_store_mgr: DataStoreMgr
 ):
@@ -174,7 +168,6 @@ async def test_update_contact_with_contact_data(
     assert api_version == data_store_mgr.data[w_id]['workflow'].api_version
 
 
-@pytest.mark.asyncio
 async def test_disconnect_workflow(
     data_store_mgr: DataStoreMgr
 ):
@@ -197,7 +190,6 @@ async def test_disconnect_workflow(
     assert data_store_mgr.data[w_id]['workflow'].api_version == 0
 
 
-@pytest.mark.asyncio
 async def test_workflow_connect_fail(
     data_store_mgr: DataStoreMgr,
     port_range,

cylc/uiserver/tests/test_workflows_mgr.py

@@ -40,7 +40,6 @@
 
 # --- workflow_request
 
-@pytest.mark.asyncio
 async def test_workflow_request_client_timeout(
         async_client: AsyncClientFixture):
     async_client.will_return(ClientTimeout)
@@ -49,7 +48,6 @@ async def test_workflow_request_client_timeout(
     assert 'timeout' in msg.lower()  # type: ignore[attr-defined]
 
 
-@pytest.mark.asyncio
 async def test_workflow_request_client_error(
         async_client: AsyncClientFixture, caplog):
     caplog.set_level(logging.CRITICAL, logger='cylc')
@@ -59,7 +57,6 @@ async def test_workflow_request_client_error(
     assert not msg
 
 
-@pytest.mark.asyncio
 @pytest.mark.parametrize(
     "returns,command,req_context,expected_ctx,expected_msg",
     [
@@ -125,7 +122,6 @@ def mk_flow(path, reg, active=True, database=True):
             )
 
 
-@pytest.mark.asyncio
 @pytest.mark.parametrize(
     # generate all possible normal state changes
     'active_before,active_after',
@@ -169,7 +165,6 @@ async def test_workflow_state_changes(tmp_path, active_before, active_after):
     'active_before,active_after',
     product([True, False], repeat=2)
 )
-@pytest.mark.asyncio
 async def test_workflow_state_change_uuid(
     tmp_path,
     active_before,
@@ -229,7 +224,6 @@ async def test_workflow_state_change_uuid(
         assert changes[0][3][CFF.UUID] == '42'
 
 
-@pytest.mark.asyncio
 async def test_multi_request(
     workflows_manager,
     async_client: AsyncClientFixture
@@ -259,7 +253,6 @@ async def test_multi_request(
     assert value == response[0]
 
 
-@pytest.mark.asyncio
 async def test_multi_request_gather_errors(
     workflows_manager,
     async_client: AsyncClientFixture,

cylc/uiserver/tests/test_workflows_mgr_data_store.py

@@ -54,7 +54,6 @@ def sync_capture(func, *_):
     return uis
 
 
-@pytest.mark.asyncio
 @pytest.mark.parametrize(
     'before,after,actions',
     [

pyproject.toml

@@ -10,7 +10,10 @@ build-backend = "setuptools.build_meta"
 addopts = """
     --doctest-modules
     --doctest-continue-on-failure
+    -p no:asyncio
 """
+# Note: disabled pytest-asyncio to avoid conflict with pytest-tornasync
+# The latter should be capable of running the async tests anyway
 doctest_optionflags = """
     NORMALIZE_WHITESPACE
     IGNORE_EXCEPTION_DETAIL

setup.cfg

@@ -90,7 +90,6 @@ tests =
     flake8-simplify>=0.14.0
     flake8>=3.0.0
     mypy>=0.900
-    pytest-asyncio>=0.14.0
     pytest-cov>=2.8.0
     pytest-tornasync>=0.5.0
     pytest>=6