chore: make icons builds from source and remove ts-node entry point to make ESM compatible

Author: AtofStryker

.circleci/src/pipeline/@pipeline.yml

@@ -1784,7 +1784,7 @@ jobs:
                   source ./scripts/ensure-node.sh
                   yarn lerna run types
             - sanitize-verify-and-store-mocha-results:
-                expectedResultCount: 10
+                expectedResultCount: 9
 
   verify-release-readiness:
     <<: *defaults

guides/esm-migration.md

@@ -46,9 +46,8 @@ When migrating some of these projects away from the `ts-node` entry [see `@packa
 - [ ] packages/example
 - [ ] packages/extension
 - [ ] packages/frontend-shared **PARTIAL** - entry point is JS
-- [ ] packages/https-proxy - higher priority
 - [x] packages/electron ✅ **COMPLETED**
-- [ ] packages/https-proxy **PARTIAL** - entry point is JS
+- [ ] packages/https-proxy - higher priority
 - [x] packages/icons ✅ **COMPLETED**
 - [x] packages/launcher ✅ **COMPLETED**
 - [x] packages/launchpad ✅ **COMPLETED**
@@ -98,7 +97,6 @@ When migrating some of these projects away from the `ts-node` entry [see `@packa
 - [ ] packages/extension
 - [ ] packages/https-proxy
 - [x] packages/electron ✅ **COMPLETED**
-- [ ] packages/https-proxy
 - [ ] packages/icons
 - [ ] packages/launcher
 - [ ] packages/net-stubbing

packages/icons/.eslintignore

@@ -1,4 +1,5 @@
 **/dist
+index.js
 **/*.d.ts
 **/package-lock.json
 **/tsconfig.json

packages/icons/.gitignore

@@ -0,0 +1,3 @@
+**/dist
+index.js
+index.d.ts

packages/icons/index.d.ts

@@ -1,6 +1,6 @@
 import path from 'path'
 
-const dist = [__dirname, '..', 'dist']
+const dist = [__dirname, 'dist']
 
 function distPath (...args: string[]) {
   return path.join.apply(path, dist.concat([...args]))

packages/icons/index.js

@@ -5,8 +5,12 @@
   "private": true,
   "main": "index.js",
   "scripts": {
-    "build": "tsx ./scripts/build.ts && tsx ./scripts/ico.ts",
-    "check-ts": "tsc --noEmit && yarn -s tslint",
+    "build": "yarn build-assets && yarn build:cjs && yarn build:esm",
+    "build-assets": "tsx ./scripts/build.ts && tsx ./scripts/ico.ts",
+    "build-prod": "yarn build",
+    "build:cjs": "tsc -p tsconfig.cjs.json",
+    "build:esm": "tsc -p tsconfig.esm.json",
+    "check-ts": "tsc -p tsconfig.cjs.json --noEmit && yarn -s tslint -p tsconfig.cjs.json",
     "lint": "eslint --ext .js,.jsx,.ts,.tsx,.json, .",
     "test": "yarn test-unit",
     "test-unit": "vitest run",
@@ -17,14 +21,15 @@
     "@types/to-ico": "^1.1.1",
     "fs-extra": "9.1.0",
     "to-ico": "^1.1.5",
-    "tsx": "^4.19.3",
+    "tsx": "^4.20.5",
     "vitest": "^3.2.4"
   },
   "files": [
     "dist",
     "index.js",
     "index.d.ts"
   ],
+  "types": "index.d.ts",
   "license": "MIT",
   "nx": {}
 }

packages/icons/src/icons.ts renamed to packages/icons/index.ts

@@ -1,5 +1,5 @@
 import { describe, it, expect } from 'vitest'
-import * as icons from '../src/icons'
+import * as icons from '../index'
 
 const cwd = process.cwd()
 

packages/icons/package.json

@@ -0,0 +1,13 @@
+{
+  "include": [
+    "index.ts"
+  ],
+  "compilerOptions": {
+    "allowJs": false,
+    "noImplicitAny": true,
+    "noUncheckedIndexedAccess": true,
+    "skipLibCheck": true,
+    "esModuleInterop": true,
+    "declaration": true
+  }
+}