Don't use printf unless needed, use bash for the shebangs

Author: eepykate

Diff for: scripts/addition.sh

@@ -1,8 +1,7 @@
-#!/bin/sh
+#!/usr/bin/env bash
 
-printf 'Enter the First Number: '
+echo -n 'Enter the First Number: '
 read -r a
-printf 'Enter the Second Number: '
+echo -n 'Enter the Second Number: '
 read -r b
-x=$((a+b))
-printf '%s\n' "$a + $b = $x"
+echo "$a + $b = $((a+b))"

Diff for: scripts/affect.sh

@@ -1,9 +1,9 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 arr=('-' '\' '|' '/')
 while true; do
 	for c in "${arr[@]}"; do
-		printf "\r %c " $c
+		echo -en "\r $c "
 		sleep .5
 	done
 done

Diff for: scripts/archive-and-encrypt.sh

@@ -1,6 +1,6 @@
-#!/bin/sh
+#!/usr/bin/env bash
 name=$1
 path=$2
-tar -czvf "$name".tar.gz "$path"
+tar -czvf "$name.tar.gz" "$path"
 gpg -c "$name.tar.gz"
 rm -rf "$name.tar.gz"

Diff for: scripts/armstrong.sh

@@ -1,9 +1,9 @@
-#!/bin/sh
-printf "Enter A Number: "
+#!/usr/bin/env bash
+echo -n "Enter A Number: "
 read -r n
 arm=0
 temp=$n
-while [ $n -ne 0 ]; do
+while [ "$n" -ne 0 ]; do
 	r=$((n % 10))
 	arm=$((arm + r * r * r))
 	n=$((n / 10))

Diff for: scripts/binary2decimal.sh

@@ -1,5 +1,5 @@
-#!/bin/sh
-printf "Enter a number: "
+#!/usr/bin/env bash
+echo -n "Enter a number: "
 read -r binary
 if [ "$binary" -eq 0 ]; then
 	echo "Enter a valid number "

Diff for: scripts/color.sh

@@ -1,6 +1,6 @@
-#!/bin/sh
+#!/usr/bin/env bash
 
-for c in 90 31 91 32 33 34 35 95 36 97 ;do
-	printf '\r \033[%sm LOVE \033[0m ' "$c"
+for c in 90 31 91 32 33 34 35 95 36 97; do
+	echo -en "\r \e[${c}m LOVE \e[0m "
 	sleep 1
 done

Diff for: scripts/convertlowercase.sh

@@ -1,11 +1,11 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
-printf "Enter File Name: "
+echo -n "Enter File Name: "
 read -r file
 
 if [ ! -f "$file" ]; then
 	echo "Filename $file does not exists"
 	exit 1
 fi
 
-tr '[:upper:]' '[:lower:]' <"$file" >>small.txt
+tr '[:upper:]' '[:lower:]' < "$file" >> small.txt

Diff for: scripts/count-lines.sh

@@ -1,3 +1,3 @@
-#!/bin/sh
+#!/usr/bin/env bash
 
 wc -l ./*

Diff for: scripts/dec2hex.sh

@@ -1,2 +1,2 @@
-#!/bin/sh
+#!/usr/bin/env bash
 printf "0x%x\n" "$1"

Diff for: scripts/decimal2binary.sh

@@ -1,7 +1,7 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 for ((i = 32; i >= 0; i--)); do
-	r=$((2 ** $i))
+	r=$((2 ** i))
 	Probablity+=($r)
 done
 
@@ -11,7 +11,7 @@ done
 }
 
 echo -en "Decimal\t\tBinary\n"
-for input_int in $@; do
+for input_int; do
 	s=0
 	test ${#input_int} -gt 11 && {
 		echo "Support Upto 10 Digit number :: skiping \"$input_int\""
@@ -22,12 +22,12 @@ for input_int in $@; do
 
 	for n in ${Probablity[@]}; do
 
-		if [[ $input_int -lt ${n} ]]; then
+		if [[ $input_int -lt $n ]]; then
 			[[ $s == 1 ]] && printf "%d" 0
 		else
-			printf "%d" 1
+			echo -n 1
 			s=1
-			input_int=$(($input_int - ${n}))
+			input_int=$((input_int - n))
 		fi
 	done
 	echo -e

Diff for: scripts/directorysize.sh

@@ -1,5 +1,5 @@
 #!/bin/bash
 
-printf " Enter your directory: "
+echo -n "Enter your directory: "
 read -r x
 du -sh "$x"

Diff for: scripts/division.sh

@@ -1,6 +1,6 @@
 #!/bin/bash
-printf 'Enter the First Number: '
+echo -n 'Enter the First Number: '
 read a
-printf "Enter the Second Number: "
+echo -n "Enter the Second Number: "
 read b
 echo "$a / $b = $((a / b))"

Diff for: scripts/encrypt.sh

@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/usr/bin/env bash
 
 echo "Welcome, I am ready to encrypt a file/folder for you"
 echo "currently I have a limitation, Place me to the same folder, where a file to be encrypted is present"

Diff for: scripts/evenodd.sh

@@ -1,8 +1,7 @@
-#!/bin/bash
-printf "Enter The Number:"
+#!/usr/bin/env bash
+echo -n "Enter The Number: "
 read -r n
-num=$((n % 2))
-if [ $num -eq 0 ]; then
+if [ $((n % 2)) -eq 0 ]; then
 	echo "is a Even Number"
 else
 	echo "is a Odd Number"

Diff for: scripts/factorial.sh

@@ -1,5 +1,5 @@
-#!/bin/sh
-printf "Enter The Number: "
+#!/usr/bin/env bash
+echo -n "Enter The Number: "
 read -r a
 fact=1
 while [ "$a" -ne 0 ]; do

Diff for: scripts/fibonacci.sh

@@ -1,10 +1,10 @@
-#!/bin/sh
+#!/usr/bin/env bash
 
 x=0; y=1; i=2
 while true; do
 	i=$((i + 1))
 	z=$((x + y))
-	printf %s "$z "
+	echo -n "$z "
 	x=$y
 	y=$z
 	sleep .5

Diff for: scripts/hello-world.sh

@@ -1,2 +1,2 @@
-#!/bin/sh
+#!/usr/bin/env bash
 echo "Hello World!"

Diff for: scripts/hextodec.sh

@@ -1,2 +1,2 @@
-#!/bin/sh
+#!/usr/bin/env bash
 printf "%d\n " "$1"

Diff for: scripts/list-dir.sh

@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/usr/bin/env bash
 
 set -- *
 

Diff for: scripts/lowercase.sh

@@ -1,4 +1,4 @@
-#!/bin/sh
-printf "Enter String Uppercase: "
+#!/usr/bin/env bash
+echo -n "Enter String Uppercase: "
 read -r i
 echo "$i" | tr '[:upper:]' '[:lower:]'

Diff for: scripts/multiplication.sh

@@ -1,6 +1,6 @@
-#!/bin/sh
-printf "Enter the First Number: "
+#!/usr/bin/env bash
+echo -n "Enter the First Number: "
 read a
-printf "Enter the Second Number: "
+echo -n "Enter the Second Number: "
 read b
 echo "$a * $b = $((a * b))"

Diff for: scripts/prime.sh

@@ -1,5 +1,5 @@
-#!/bin/sh
-printf "Enter Any Number: "
+#!/usr/bin/env bash
+echo -n "Enter Any Number: "
 read -r n
 i=1; c=1
 while [ $i -le "$n" ]; do

Diff for: scripts/process.sh

@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/usr/bin/env bash
 echo "Hello $USER"
 echo "Hey i am $USER and will be telling you about the current processes"
 echo "Running processes List"

Diff for: scripts/random-emoji.sh

@@ -1,7 +1,7 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 while true; do
 	rand=$(shuf -i 2600-2700 -n 1)
-	printf "   \u$rand"
+	echo -en "   \u$rand"
 	sleep 1
 done

Diff for: scripts/randomfile.sh

@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/usr/bin/env bash
 
 echo "Hello $USER"
 uptime >> "$(date)".txt

Diff for: scripts/rang-random.sh

@@ -1,3 +1,3 @@
-#!/bin/sh
+#!/usr/bin/env bash
 
 shuf -i "$1-$2" -n 1

Diff for: scripts/read-menu.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 # read-menu: a menu driven system information program
 clear
 cat << EOF
@@ -10,7 +10,7 @@ Please Select:
     0. Quit
 
 EOF
-printf 'Enter selection [0-3]: '
+echo -n 'Enter selection [0-3]: '
 read -r sel
 
 case $sel in

Diff for: scripts/substraction.sh

@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/usr/bin/env bash
 printf "Enter the First Number: "
 read -r a
 printf "Enter the Second Number: "

Diff for: scripts/table.sh

@@ -1,5 +1,5 @@
-#!/bin/sh
-printf "Enter The Number upto which you want to Print Table: "
+#!/usr/bin/env bash
+echo -n "Enter The Number upto which you want to Print Table: "
 read -r n
 i=1
 while [ $i -ne 10 ]; do