Setup: If root access is available show additional explanation for Shizuku

Closes #1238

Author: d4rken

app/src/main/java/eu/darken/sdmse/setup/shizuku/ShizukuSetupCardVH.kt

@@ -36,6 +36,14 @@ class ShizukuSetupCardVH(parent: ViewGroup) :
             }
         }
 
+        body.apply {
+            text = getString(R.string.setup_shizuku_card_body)
+            if (item.state.alsoHasRoot) {
+                append("\n")
+                append(getString(R.string.setup_shizuku_card_root_info))
+            }
+        }
+
         shizukuState.apply {
             isVisible = item.state.useShizuku == true && item.state.isInstalled
             text = getString(

app/src/main/java/eu/darken/sdmse/setup/shizuku/ShizukuSetupModule.kt

@@ -13,6 +13,7 @@ import eu.darken.sdmse.common.debug.logging.logTag
 import eu.darken.sdmse.common.flow.replayingShare
 import eu.darken.sdmse.common.pkgs.Pkg
 import eu.darken.sdmse.common.rngString
+import eu.darken.sdmse.common.root.RootManager
 import eu.darken.sdmse.common.shizuku.ShizukuManager
 import eu.darken.sdmse.common.shizuku.ShizukuSettings
 import eu.darken.sdmse.common.shizuku.canUseShizukuNow
@@ -41,7 +42,8 @@ class ShizukuSetupModule @Inject constructor(
     @AppScope private val appScope: CoroutineScope,
     private val shizukuSettings: ShizukuSettings,
     private val shizukuManager: ShizukuManager,
-    private val dataAreaManager: DataAreaManager
+    private val dataAreaManager: DataAreaManager,
+    private val rootManager: RootManager,
 ) : SetupModule {
 
     private val refreshTrigger = MutableStateFlow(rngString)
@@ -59,12 +61,14 @@ class ShizukuSetupModule @Inject constructor(
     override val state: Flow<SetupModule.State> = combine(
         refreshTrigger,
         shizukuSettings.useShizuku.flow,
-    ) { _, useShizuku ->
+        rootManager.useRoot,
+    ) { _, useShizuku, useRoot ->
         val baseState = Result(
             pkg = shizukuManager.pkgId,
             useShizuku = useShizuku,
             isInstalled = shizukuManager.isInstalled(),
             isCompatible = shizukuManager.isCompatible(),
+            alsoHasRoot = useRoot,
         )
 
         if (useShizuku != true) return@combine flowOf(baseState)
@@ -79,7 +83,7 @@ class ShizukuSetupModule @Inject constructor(
             baseState.copy(
                 basicService = binder?.pingBinder() ?: false,
                 ourService = shizukuManager.isShizukuServiceAvailable(),
-            )as SetupModule.State
+            ) as SetupModule.State
         }
     }
         .flatMapLatest { it }
@@ -137,6 +141,7 @@ class ShizukuSetupModule @Inject constructor(
         val isInstalled: Boolean = false,
         val basicService: Boolean = false,
         val ourService: Boolean = false,
+        val alsoHasRoot: Boolean = false,
     ) : SetupModule.State.Current {
 
         override val type: SetupModule.Type = SetupModule.Type.SHIZUKU

app/src/main/res/values/strings.xml

@@ -136,6 +136,7 @@
     <string name="setup_shizuku_card_title">Shizuku</string>
     <string name="setup_shizuku_card_body">Allow SD Maid to use Shizuku where possible to improve results and enable features.</string>
     <string name="setup_shizuku_card_body2">This setting has no effect if the Shizuku app is not set up on your device.</string>
+    <string name="setup_shizuku_card_root_info">Shizuku in combination with root access does not enable additional features, but it improves reliability. SD Maid will use it as fallback method.</string>
     <string name="setup_shizuku_state_ready_label">Shizuku link is ready.</string>
     <string name="setup_shizuku_state_waiting_label">Waiting for link with Shizuku.</string>
     <string name="setup_shizuku_enable_shizuku_use_label">Use Shizuku if available</string>