Skip to content

Latest commit

 

History

History
39 lines (30 loc) · 1.74 KB

pull_request_template.md

File metadata and controls

39 lines (30 loc) · 1.74 KB

Summary

Closes #

Validation

Checklist

The full gate list is in CONTRIBUTING.md: Before you open a PR. These are the steps most often missed.

  • The PR targets dev, the title is a Conventional Commit, and every commit is signed.
  • make ci and make slither pass. A gas change commits the make snapshot diff.
  • A behavior change has regression tests through a diamond built from the module's recipe, and the Validation section separates offline coverage from fork coverage.
  • A new or changed ERC-7201 struct is imported into script/upgrades/StorageLayoutProbe.sol, its baseline diff from make storage-update is reviewed, and STORAGE_REGISTRY.md has its row.
  • A new interface has its ERC165_MAP_I<MODULE>_SLOT constant and registerInterface(), per the registerInterface standard, plus a slot test.
  • Ported or adapted code carries the attribution line.
  • No namespace or interfaceId that is live on any network has changed.

Passing CI is not an audit.