refactor: address code review feedback on AzureQueueStorage transport

Agent-Logs-Url: https://github.com/dailydevops/pulse/sessions/46d27db2-a16d-482b-8d30-a7fa998b9eb8

Co-authored-by: samtrion <3283596+samtrion@users.noreply.github.com>

Author: Copilot

src/NetEvolve.Pulse.AzureQueueStorage/Outbox/AzureQueueStorageMessageTransport.cs

@@ -20,14 +20,12 @@ namespace NetEvolve.Pulse.Outbox;
 /// </remarks>
 public sealed class AzureQueueStorageMessageTransport : IMessageTransport, IDisposable
 {
-    internal const int MaxMessageSizeInBytes = 48 * 1024; // 48 KB
+    internal const int MaxMessageSizeInBytes = 48 * 1024; // Raw 48 KB limit (64 KB after Base64 encoding)
 
     private readonly AzureQueueStorageTransportOptions _options;
     private readonly QueueClient? _queueClientOverride;
     private readonly SemaphoreSlim _initLock = new SemaphoreSlim(1, 1);
-
-    // Volatile ensures the double-checked locking pattern is correct across threads.
-    private volatile QueueClient? _queueClient;
+    private QueueClient? _queueClient;
 
     /// <summary>
     /// Initializes a new instance of the <see cref="AzureQueueStorageMessageTransport"/> class.
@@ -143,7 +141,7 @@ private async Task<QueueClient> GetQueueClientAsync(CancellationToken cancellati
             }
             else
             {
-                var queueUri = new Uri($"{_options.QueueServiceUri!.AbsoluteUri.TrimEnd('/')}/{_options.QueueName}");
+                var queueUri = new Uri(_options.QueueServiceUri!, _options.QueueName);
                 client = new QueueClient(queueUri, new DefaultAzureCredential());
             }
 

tests/NetEvolve.Pulse.Tests.Unit/AzureQueueStorage/AzureQueueStorageMessageTransportTests.cs

@@ -244,7 +244,7 @@ private sealed class FakeQueueClient : QueueClient
         [System.Diagnostics.CodeAnalysis.SuppressMessage(
             "Reliability",
             "CA2000:Dispose objects before losing scope",
-            Justification = "FakeAzureResponse.Dispose is a no-op; suppressed for test code."
+            Justification = "FakeAzureResponse is passed to Response.FromValue and immediately returned; its Dispose is a no-op."
         )]
         public override Task<Response<SendReceipt>> SendMessageAsync(
             string messageText,
@@ -268,7 +268,7 @@ public override Task<Response<SendReceipt>> SendMessageAsync(
         [System.Diagnostics.CodeAnalysis.SuppressMessage(
             "Reliability",
             "CA2000:Dispose objects before losing scope",
-            Justification = "FakeAzureResponse.Dispose is a no-op; suppressed for test code."
+            Justification = "FakeAzureResponse is immediately returned as the raw response; its Dispose is a no-op."
         )]
         public override Task<Response> CreateIfNotExistsAsync(
             IDictionary<string, string>? metadata = null,