Skip to content

Commit

Permalink
Cleanup unused imports
Browse files Browse the repository at this point in the history
  • Loading branch information
turekj committed Feb 6, 2020
1 parent 1d90010 commit 1401657
Show file tree
Hide file tree
Showing 16 changed files with 13 additions and 48 deletions.
2 changes: 2 additions & 0 deletions danger_python/__init__.py
Original file line number Diff line number Diff line change
@@ -1 +1,3 @@
from danger_python.danger import Danger, fail, markdown, message, warn

__all__ = ["Danger", "fail", "markdown", "message", "warn"]
9 changes: 3 additions & 6 deletions danger_python/cli.py
Original file line number Diff line number Diff line change
@@ -1,15 +1,12 @@
import functools
import subprocess
import sys
import traceback
from typing import List

import click
from click_default_group import DefaultGroup

from click_default_group import DefaultGroup
from danger_python.decorators import danger_command
from danger_python.exceptions import DangerfileException, SystemConfigurationException
from danger_python.shell import execute_dangerfile, invoke_danger, resolve_danger_path
from danger_python.exceptions import DangerfileException
from danger_python.shell import execute_dangerfile, invoke_danger


@click.group(cls=DefaultGroup, default="run", default_if_no_args=True)
Expand Down
1 change: 0 additions & 1 deletion danger_python/danger.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
from typing import Any, Callable, Dict, List, Optional

from pydantic import BaseModel
from pydantic.dataclasses import dataclass

from .models import (
BitBucketCloudJSONDSL,
Expand Down
5 changes: 0 additions & 5 deletions danger_python/decorators.py
Original file line number Diff line number Diff line change
@@ -1,10 +1,5 @@
import functools
from typing import List

import click

from danger_python.shell import invoke_danger


def danger_command(cli, command_name: str):
def wrapper(func):
Expand Down
3 changes: 1 addition & 2 deletions danger_python/generator/builder.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
from collections import OrderedDict
from functools import reduce
from itertools import chain
from operator import attrgetter
from typing import Any, Dict, Iterable, List, Optional, Set, Tuple
from typing import Iterable, List, Optional

import stringcase

Expand Down
1 change: 0 additions & 1 deletion danger_python/plugins.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import sys
from typing import Optional

from .danger import Danger, fail, markdown, message, warn

Expand Down
2 changes: 1 addition & 1 deletion danger_python/shell.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import sys
import traceback
from types import TracebackType
from typing import List, Optional
from typing import List

from .danger import Danger, fail, markdown, message, serialize_results, warn
from .exceptions import DangerfileException, SystemConfigurationException
Expand Down
3 changes: 0 additions & 3 deletions scripts/generate_scheme.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
import json
import os
import shutil
from dataclasses import dataclass
from typing import List, Optional

from danger_python.generator.builder import build_types
from danger_python.generator.parser import parse_schema
Expand Down
1 change: 1 addition & 0 deletions setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ ignore = E203, E266, E501, W503
max-line-length = 88
max-complexity = 18
select = B,C,E,F,W,T4
exclude = dangerfile.py

[mypy]
files=danger_python,tests
Expand Down
10 changes: 1 addition & 9 deletions tests/fixtures/danger.py
Original file line number Diff line number Diff line change
@@ -1,15 +1,7 @@
import json
import sys
from contextlib import contextmanager
from io import StringIO
from typing import Any, Dict, Iterator, List, Optional
from unittest import mock
from typing import Any, Dict

import pytest
from jinja2 import Environment, PackageLoader, select_autoescape

from danger_python.danger import Danger


def danger_input_file_fixture(**kwargs: Dict[str, Any]) -> str:
template_environment = Environment(
Expand Down
3 changes: 0 additions & 3 deletions tests/fixtures/shell.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
import subprocess
from contextlib import contextmanager
from dataclasses import dataclass
from typing import Any, Dict, List, Optional
from unittest import mock


@dataclass
Expand Down
4 changes: 1 addition & 3 deletions tests/generator/test_parser.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import pytest

from danger_python.generator.models import (
SchemaAllOf,
SchemaAnyOf,
Expand Down Expand Up @@ -115,7 +113,7 @@ def test_schema_parser_parses_definitions():
properties=[
SchemaObject(
name="html",
properties=[SchemaValue(name="href", value_type="string"),],
properties=[SchemaValue(name="href", value_type="string")],
),
SchemaReference(name="ref_property", reference="BitBucketCloudPRDSL"),
],
Expand Down
1 change: 0 additions & 1 deletion tests/generator/test_renderer.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
ClassDefinition,
EnumDefinition,
PropertyDefinition,
TypeDefinition,
)
from danger_python.generator.renderer import render_classes

Expand Down
2 changes: 0 additions & 2 deletions tests/test_cli.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
import json
from typing import List
from unittest import mock

import pytest
from click.testing import CliRunner
Expand Down
9 changes: 3 additions & 6 deletions tests/test_danger.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
import sys
from io import StringIO
from typing import Dict
from unittest import mock

import pytest

Expand Down Expand Up @@ -56,9 +53,9 @@ def test_results_are_correctly_serialized():
json = serialize_results(results)

assert json == {
"fails": [{"message": "Fail"},],
"warnings": [{"message": "Warning", "file": "warning.py", "line": 99},],
"messages": [{"message": "Message"},],
"fails": [{"message": "Fail"}],
"warnings": [{"message": "Warning", "file": "warning.py", "line": 99}],
"messages": [{"message": "Message"}],
"markdowns": [{"message": "Markdown"}],
}

Expand Down
5 changes: 0 additions & 5 deletions tests/test_shell.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,3 @@
import subprocess
import sys
from io import StringIO
from unittest import mock

import pytest

from danger_python.exceptions import DangerfileException, SystemConfigurationException
Expand Down

0 comments on commit 1401657

Please sign in to comment.