Skip to content

Commit

Permalink
Fix GitHub review states to have correct values
Browse files Browse the repository at this point in the history
  • Loading branch information
turekj committed Feb 14, 2020
1 parent d4f8397 commit 302097d
Show file tree
Hide file tree
Showing 2 changed files with 32 additions and 2 deletions.
5 changes: 3 additions & 2 deletions danger_python/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -1152,9 +1152,10 @@ class Config:

class GitHubReviewState(Enum):
APPROVED = "APPROVED"
COMMENT = "COMMENT"
CHANGES_REQUESTED = "CHANGES_REQUESTED"
COMMENTED = "COMMENTED"
DISMISSED = "DISMISSED"
PENDING = "PENDING"
REQUEST_CHANGES = "REQUEST_CHANGES"


class GitHubReviewers(BaseModel):
Expand Down
29 changes: 29 additions & 0 deletions tests/test_models.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
import pytest

from danger_python.models import DangerDSLJSONType, GitHubReviewState


def test_github_dsl_handles_correct_review_states():
"""
Test that GitHub DSL handles correct review states.
"""
dsl_json = {
"github": {
"reviews": [
{"state": "APPROVED"},
{"state": "CHANGES_REQUESTED"},
{"state": "COMMENTED"},
{"state": "PENDING"},
{"state": "DISMISSED"},
]
}
}

dsl = DangerDSLJSONType(**dsl_json)

assert len(dsl.github.reviews) == 5
assert dsl.github.reviews[0].state == GitHubReviewState.APPROVED
assert dsl.github.reviews[1].state == GitHubReviewState.CHANGES_REQUESTED
assert dsl.github.reviews[2].state == GitHubReviewState.COMMENTED
assert dsl.github.reviews[3].state == GitHubReviewState.PENDING
assert dsl.github.reviews[4].state == GitHubReviewState.DISMISSED

0 comments on commit 302097d

Please sign in to comment.