add query string in an http get method for graphql query

Author: danielnaveda

.travis.yml

@@ -12,5 +12,5 @@ install:
 script:
   - go get -t -v ./...
   - diff -u <(echo -n) <(gofmt -d -s .)
-  - go tool vet .
+  - go vet .
   - go test -v -race ./...

README.md

@@ -1,7 +1,7 @@
 graphql
 =======
 
-[![Build Status](https://travis-ci.org/shurcooL/graphql.svg?branch=master)](https://travis-ci.org/shurcooL/graphql) [![GoDoc](https://godoc.org/github.com/shurcooL/graphql?status.svg)](https://godoc.org/github.com/shurcooL/graphql)
+[![Build Status](https://travis-ci.org/shurcooL/graphql.svg?branch=master)](https://travis-ci.org/shurcooL/graphql) [![GoDoc](https://godoc.org/github.com/danielnaveda/graphql?status.svg)](https://godoc.org/github.com/danielnaveda/graphql)
 
 Package `graphql` provides a GraphQL client implementation.
 
@@ -15,7 +15,7 @@ Installation
 `graphql` requires Go version 1.8 or later.
 
 ```bash
-go get -u github.com/shurcooL/graphql
+go get -u github.com/danielnaveda/graphql
 ```
 
 Usage
@@ -283,9 +283,9 @@ Directories
 
 | Path                                                                                   | Synopsis                                                                                                        |
 |----------------------------------------------------------------------------------------|-----------------------------------------------------------------------------------------------------------------|
-| [example/graphqldev](https://godoc.org/github.com/shurcooL/graphql/example/graphqldev) | graphqldev is a test program currently being used for developing graphql package.                               |
-| [ident](https://godoc.org/github.com/shurcooL/graphql/ident)                           | Package ident provides functions for parsing and converting identifier names between various naming convention. |
-| [internal/jsonutil](https://godoc.org/github.com/shurcooL/graphql/internal/jsonutil)   | Package jsonutil provides a function for decoding JSON into a GraphQL query data structure.                     |
+| [example/graphqldev](https://godoc.org/github.com/danielnaveda/graphql/example/graphqldev) | graphqldev is a test program currently being used for developing graphql package.                               |
+| [ident](https://godoc.org/github.com/danielnaveda/graphql/ident)                           | Package ident provides functions for parsing and converting identifier names between various naming convention. |
+| [internal/jsonutil](https://godoc.org/github.com/danielnaveda/graphql/internal/jsonutil)   | Package jsonutil provides a function for decoding JSON into a GraphQL query data structure.                     |
 
 License
 -------

doc.go

@@ -8,4 +8,4 @@
 // opportunities for improvement are discovered; it is not yet frozen.
 //
 // For now, see README for more details.
-package graphql // import "github.com/shurcooL/graphql"
+package graphql // import "github.com/danielnaveda/graphql"

example/graphqldev/main.go

@@ -14,10 +14,10 @@ import (
 	"net/http/httptest"
 	"os"
 
+	"github.com/danielnaveda/graphql"
 	graphqlserver "github.com/graph-gophers/graphql-go"
 	"github.com/graph-gophers/graphql-go/example/starwars"
 	"github.com/graph-gophers/graphql-go/relay"
-	"github.com/shurcooL/graphql"
 )
 
 func main() {

graphql.go

@@ -7,15 +7,17 @@ import (
 	"fmt"
 	"io/ioutil"
 	"net/http"
+	"net/url"
 
-	"github.com/shurcooL/graphql/internal/jsonutil"
+	"github.com/danielnaveda/graphql/internal/jsonutil"
 	"golang.org/x/net/context/ctxhttp"
 )
 
 // Client is a GraphQL client.
 type Client struct {
-	url        string // GraphQL server URL.
-	httpClient *http.Client
+	url         string // GraphQL server URL.
+	httpClient  *http.Client
+	queryString queryType
 }
 
 // NewClient creates a GraphQL client targeting the specified GraphQL server URL.
@@ -25,11 +27,24 @@ func NewClient(url string, httpClient *http.Client) *Client {
 		httpClient = http.DefaultClient
 	}
 	return &Client{
-		url:        url,
-		httpClient: httpClient,
+		url:         url,
+		httpClient:  httpClient,
+		queryString: disabled,
 	}
 }
 
+// EnableQueryString enables query string mode for graphql queries
+func (c *Client) EnableQueryString() *Client {
+	c.queryString = enabled
+	return c
+}
+
+// DisableQueryString disables query string mode for graphql queries
+func (c *Client) DisableQueryString() *Client {
+	c.queryString = disabled
+	return c
+}
+
 // Query executes a single GraphQL query request,
 // with a query derived from q, populating the response into it.
 // q should be a pointer to struct that corresponds to the GraphQL schema.
@@ -65,7 +80,14 @@ func (c *Client) do(ctx context.Context, op operationType, v interface{}, variab
 	if err != nil {
 		return err
 	}
-	resp, err := ctxhttp.Post(ctx, c.httpClient, c.url, "application/json", &buf)
+
+	var resp *http.Response
+	if op == queryOperation && c.queryString == enabled {
+		resp, err = GetWithQueryString(ctx, c.httpClient, c.url, query, variables)
+	} else {
+		resp, err = ctxhttp.Post(ctx, c.httpClient, c.url, "application/json", &buf)
+	}
+
 	if err != nil {
 		return err
 	}
@@ -121,3 +143,22 @@ const (
 	mutationOperation
 	//subscriptionOperation // Unused.
 )
+
+// GetWithQueryString sends an http get request with the query and variables as a query string
+func GetWithQueryString(ctx context.Context, client *http.Client, graphqlURL string, query string, variables map[string]interface{}) (*http.Response, error) {
+	queryString := url.QueryEscape(query)
+	variableBytes, err := json.Marshal(variables)
+	if err != nil {
+		return &http.Response{}, err
+	}
+	variableString := url.QueryEscape(string(variableBytes))
+	resp, err := ctxhttp.Get(ctx, client, graphqlURL+`?query=`+queryString+`&variables=`+variableString)
+	return resp, err
+}
+
+type queryType uint8
+
+const (
+	disabled queryType = iota
+	enabled
+)

graphql_test.go

@@ -8,7 +8,7 @@ import (
 	"net/http/httptest"
 	"testing"
 
-	"github.com/shurcooL/graphql"
+	"github.com/danielnaveda/graphql"
 )
 
 func TestClient_Query_partialDataWithErrorResponse(t *testing.T) {

ident/ident_test.go

@@ -5,7 +5,7 @@ import (
 	"reflect"
 	"testing"
 
-	"github.com/shurcooL/graphql/ident"
+	"github.com/danielnaveda/graphql/ident"
 )
 
 func Example_lowerCamelCaseToMixedCaps() {

internal/jsonutil/benchmark_test.go

@@ -8,8 +8,8 @@ import (
 	"testing"
 	"time"
 
-	"github.com/shurcooL/graphql"
-	"github.com/shurcooL/graphql/internal/jsonutil"
+	"github.com/danielnaveda/graphql"
+	"github.com/danielnaveda/graphql/internal/jsonutil"
 )
 
 func TestUnmarshalGraphQL_benchmark(t *testing.T) {

internal/jsonutil/graphql_test.go

@@ -5,8 +5,8 @@ import (
 	"testing"
 	"time"
 
-	"github.com/shurcooL/graphql"
-	"github.com/shurcooL/graphql/internal/jsonutil"
+	"github.com/danielnaveda/graphql"
+	"github.com/danielnaveda/graphql/internal/jsonutil"
 )
 
 func TestUnmarshalGraphQL(t *testing.T) {

query.go

@@ -7,7 +7,7 @@ import (
 	"reflect"
 	"sort"
 
-	"github.com/shurcooL/graphql/ident"
+	"github.com/danielnaveda/graphql/ident"
 )
 
 func constructQuery(v interface{}, variables map[string]interface{}) string {

scalar_test.go

@@ -3,7 +3,7 @@ package graphql_test
 import (
 	"testing"
 
-	"github.com/shurcooL/graphql"
+	"github.com/danielnaveda/graphql"
 )
 
 func TestNewScalars(t *testing.T) {