Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial tests #81

Closed
lricoy opened this issue Dec 27, 2017 · 1 comment
Closed

Add initial tests #81

lricoy opened this issue Dec 27, 2017 · 1 comment

Comments

@lricoy
Copy link
Collaborator

lricoy commented Dec 27, 2017

I think we sould add a few unit tests and hopefully some functional as well.

Since we've bumped the node version requirement to 8+ we have more test library options now. I would rather add the tests before start refactoring the code.

Any tips on where to start @danthareja @aurelienshz ?

@danthareja
Copy link
Owner

I definitely agree with your decision to write tests before starting to refactor. Once we get some test coverage, i'll publish a major version bump.

I think a good place to start is to test the functionality of each exported command inside of lib/commands. If we stick to testing the public interface, we will have more flexibility to refactor the internals, and also have some confidence that we're not breaking the behavior users are expecting.

In terms of test libraries, as you said there are a lot of good options and I'm not tied to a particular one and encourage you to use whatever you think you will be most productive with!

@lricoy lricoy closed this as completed Jan 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants