Is it possible to disable Lenis.onVirtualScroll while holding down the Shift key?

[AleksandrIvanenko]

For now Shift + mouse wheel leads to vertical page scrolling instead of horizontal. Can this be changed by replacing this line with this code: if (event.ctrlKey || event.shiftKey)?
Are there any reasons why this has not been done?

[clementroche]

@AleksandrIvanenko Are you sure that holding Shift while scrolling should scroll horizontally on every browser ? Here is a test: https://codepen.io/ClementRoche/pen/NWVmzNm. For instance it's not the default behaviour of MacOS touchpad.

In this case it would be if(event.shiftKey && !this.isHorizontal && this.options.gestureOrientation === 'vertical') return

[AleksandrIvanenko]

@clementroche, thank you for the answer!
I can't check on a Mac because I don't have one. But on Windows in Chrome, Firefox and Safari (via Playwright) Shift + mouse wheel leads to horizontal scrolling, yes.
Your suggestion seems more reliable.

[Serator]

Some more information on the different browsers.

• Chrome: https://support.google.com/chrome/answer/157179?hl=en&co=GENIE.Platform%3DDesktop#zippy=%2Ctab-window-shortcuts%2Cgoogle-chrome-feature-shortcuts%2Cwebpage-shortcuts%2Cmouse-shortcuts%2Caddress-bar-shortcuts:~:text=End-,Scroll%20horizontally%20on%20the%20page,-Shift%20%2B%20Scroll

• Firefox: https://support.mozilla.org/en-US/kb/mouse-shortcuts-perform-common-tasks#:~:text=Scroll-,Right,-Shift

In addition, as far as I know this only applies to mouses, not trackpads and similar devices.

[clementroche]

That's the issues tho. As far as i know, this is not possible to detect if the user is scrolling from a touchpad or a mouse so any fix would be not reliable.

[AleksandrIvanenko]

Then maybe it's possible to give access to this virtual scroll interrupt externally (Lenis instance options?)? This way we can customize it without changing the source code. And responsibility for potential bugs will lie with us.

[clementroche]

That could be a solution.

[Serator]

In addition, as far as I know this only applies to mouses, not trackpads and similar devices.

On trackpads with the Shift key held down, there is simply nothing happening when scrolling, it continues vertically.

[clementroche]

hey @AleksandrIvanenko @Serator, i've just shipped a virtualScroll option that allows you to manually modify the events before they get consumed. If false is returned, the scroll will not be smoothed. Examples: (e) => { e.deltaY /= 2 } (to slow down vertical scroll) or ({ event }) => !event.shiftKey (to prevent scroll to be smoothed if shift key is pressed)

[AleksandrIvanenko]

@clementroche, looks good to me, works as expected. Thank you!