Avoid null pointer dereference in dt_mipmap_cache_get_with_caller while logging

kofa73 · TurboGit · commit 3564e77313ec · 2025-02-06T18:39:34.000+01:00
diff --git a/src/common/mipmap_cache.c b/src/common/mipmap_cache.c
@@ -1152,7 +1152,7 @@ void dt_mipmap_cache_get_with_caller(
     flags == DT_MIPMAP_PREFETCH_DISK ? "DT_MIPMAP_PREFETCH_DISK" : "",
     flags == DT_MIPMAP_BLOCKING ? "DT_MIPMAP_BLOCKING" : "",
     flags == DT_MIPMAP_BEST_EFFORT ? "DT_MIPMAP_BEST_EFFORT" : "",
-    imgid, mip, mode, buf->buf);
+    imgid, mip, mode, (buf ? buf->buf : NULL));
 }
 
 void dt_mipmap_cache_release_with_caller(dt_mipmap_cache_t *cache,

Original file line number	Diff line number	Diff line change
`@@ -1152,7 +1152,7 @@ void dt_mipmap_cache_get_with_caller(`
`1152`	`1152`	`flags == DT_MIPMAP_PREFETCH_DISK ? "DT_MIPMAP_PREFETCH_DISK" : "",`
`1153`	`1153`	`flags == DT_MIPMAP_BLOCKING ? "DT_MIPMAP_BLOCKING" : "",`
`1154`	`1154`	`flags == DT_MIPMAP_BEST_EFFORT ? "DT_MIPMAP_BEST_EFFORT" : "",`
`1155`		`- imgid, mip, mode, buf->buf);`
	`1155`	`+ imgid, mip, mode, (buf ? buf->buf : NULL));`
`1156`	`1156`	`}`
`1157`	`1157`
`1158`	`1158`	`void dt_mipmap_cache_release_with_caller(dt_mipmap_cache_t *cache,`