-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion to add some words about vectorscope color harmony buttons only to be shown when in RYB color space #726
Comments
That's a good suggestion, can you please make a pull request with that change?
…On February 7, 2025 6:21:28 AM PST, DanielFeld2020 ***@***.***> wrote:
I wondered (and finally wrote a bug report...) why my vectorscope color harmony buttons suddenly where missing. For some reason I accidently switched the color space of the vectorscope from RYB to CIELUV where those buttons are no longer shown. My error. There for sure is a reason why the buttons are only shown in RYB. I might have noticed my error if this was mentioned with a few words in the respective section of the documentation.
I suggest to change the sentence
> Finally, along the left-hand edge of the module are a series of buttons that allow the selected color harmony indicator to be overlaid on the vectorscope graphic.
to
> Finally, along the left-hand edge of the module are a series of buttons that allow the selected color harmony indicator to be overlaid on the vectorscope graphic when in RYB color space.
Or something like that.
Maybe this is mentioned somewhere else, but IMHO it should be mentioned right at this location: Module Reference / utility modules / shared / scopes / vectorscope / color harmony and additional vectorscope controls
--
Reply to this email directly or view it on GitHub:
#726
You are receiving this because you are subscribed to this thread.
Message ID: ***@***.***>
|
How can I do this? I have no experience in this. |
You can see the github docs here: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request
…On February 7, 2025 7:25:44 AM PST, DanielFeld2020 ***@***.***> wrote:
How can I do this? I have no experience in this.
--
Reply to this email directly or view it on GitHub:
#726 (comment)
You are receiving this because you commented.
Message ID: ***@***.***>
|
Well, I'm just a photographer and user of darktable without any knowledge about git. Working thru all of this took me around an hour. To add 5 words. And I'm still not sure I have done everything correctly... Pull request: #727 I know about the problems to get the darktable documentation up-to-date. I think it's already an effort for a normal user to create a git issue. Having a normal user going the extra mile of a pull request is probably the reason why too less people are willing to participate in this. It probably would have been less effort for you to slap on the 5 words instead. Anyway, thanks for you help. |
I wondered (and finally wrote a bug report...) why my vectorscope color harmony buttons suddenly where missing. For some reason I accidently switched the color space of the vectorscope from RYB to CIELUV where those buttons are no longer shown. My error. There for sure is a reason why the buttons are only shown in RYB. I might have noticed my error if this was mentioned with a few words in the respective section of the documentation.
I suggest to change the sentence
to
Or something like that.
Maybe this is mentioned somewhere else, but IMHO it should be mentioned right at this location: Module Reference / utility modules / shared / scopes / vectorscope / color harmony and additional vectorscope controls
The text was updated successfully, but these errors were encountered: