Skip to content

Commit 1dfa3c8

Browse files
committed
remove duplicate logs in transformer mode
1 parent 764d8d6 commit 1dfa3c8

File tree

4 files changed

+13
-3
lines changed

4 files changed

+13
-3
lines changed

CHANGELOG.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,10 @@
11
# Changelog
22

3+
## 0.3.0+5
4+
- Fix duplicate logs issue when running as a BuilderTransformer.
5+
36
## 0.3.0+4
4-
- Add error and stack trace to log nessages from the BuilderTransformer.
7+
- Add error and stack trace to log messages from the BuilderTransformer.
58

69
## 0.3.0+3
710
- Fixed BuilderTransformer so that logs are passed on to the TransformLogger.

lib/src/transformer/transformer.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,8 @@ abstract class BuilderTransformer implements Transformer, DeclaringTransformer {
7575
new BuildStepImpl(input, expected, reader, writer, input.id.package);
7676
Logger.root.level = Level.ALL;
7777
var logSubscription = buildStep.logger.onRecord.listen((LogRecord log) {
78+
if (log.loggerName != buildStep.logger.fullName) return;
79+
7880
if (log.level <= Level.CONFIG) {
7981
transform.logger.fine(_logRecordToMessage(log));
8082
} else if (log.level <= Level.INFO) {

pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: build
2-
version: 0.3.0+4
2+
version: 0.3.0+5
33
description: A build system for Dart.
44
author: Dart Team <[email protected]>
55
homepage: https://github.com/dart-lang/build

test/transformer/transformer_test.dart

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,12 +121,17 @@ void main() {
121121
new GenericBuilderTransformer([new LoggingCopyBuilder()])
122122
],
123123
], {
124-
'a|web/a.txt': 'hello',
124+
'a|web/a.txt': 'a',
125+
'a|web/b.txt': 'b',
125126
}, {}, messages: [
126127
allOf(startsWith('warning: Warning!'), contains('SomeError'),
127128
contains('LoggingCopyBuilder.build')),
128129
allOf(startsWith('error: Error!'), contains('SomeError'),
129130
contains('LoggingCopyBuilder.build')),
131+
allOf(startsWith('warning: Warning!'), contains('SomeError'),
132+
contains('LoggingCopyBuilder.build')),
133+
allOf(startsWith('error: Error!'), contains('SomeError'),
134+
contains('LoggingCopyBuilder.build')),
130135
]);
131136
}
132137

0 commit comments

Comments
 (0)