[vm] Add builtin TSAN suppressions

Sanitizers can pickup configuration and suppressions via
special symbols in the binary (e.g. __*_default_suppressions and
__*_default_options). We have a bunch of stale files in the
buildroot which showed how to do it, but none of these were
actually used by the build process.

Update our BUILDCONFIG.gn to actually link this code into
the binaries and clean it up leaving behind only one relevant
suppression for TSAN.

Additionally fix libplatform targets - libdart_platform_no_tsan was
accidentally disabling TSAN for the whole libplatform by adding
no_tsan_config into public_configs instead of extra_configs.

This is needed to unblock landing https://dart-review.googlesource.com/c/sdk/+/444983

TEST=manually with the referenced CL to verify that suppressions work

Cq-Include-Trybots: luci.dart.try:vm-tsan-linux-release-x64-try,vm-tsan-linux-release-arm64-try
Change-Id: Id4e8a5b89c665cf5d89b18c4f5881ef31c3c9396
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/445941
Commit-Queue: Slava Egorov <[email protected]>
Reviewed-by: Ryan Macnak <[email protected]>

Author: mraleph

build/config/BUILDCONFIG.gn

@@ -259,6 +259,9 @@ if (current_os == "win") {
 use_flutter_cxx =
     is_clang && ((is_asan && is_mac) || is_msan || is_tsan || is_ios)
 
+using_sanitizer = !is_win && (is_asan || is_hwasan || is_lsan || is_msan ||
+                              is_tsan || is_ubsan)
+
 # =============================================================================
 # TARGET DEFAULTS
 # =============================================================================
@@ -511,6 +514,7 @@ foreach(_target_type,
           deps = []
         }
         if (!defined(invoker.no_default_deps) || !invoker.no_default_deps) {
+          deps += [ "//build/config/sanitizers:deps" ]
           if (use_flutter_cxx) {
             deps += [ "//third_party/libcxx" ]
           }
@@ -653,7 +657,7 @@ if (!is_shared_library) {
         if (!defined(deps)) {
           deps = []
         }
-
+        deps += [ "//build/config/sanitizers:deps" ]
         if (use_flutter_cxx) {
           deps += [ "//third_party/libcxx" ]
         }

build/config/compiler/BUILD.gn

@@ -38,11 +38,6 @@ config("default_include_dirs") {
   ]
 }
 
-if (!is_win) {
-  using_sanitizer =
-      is_asan || is_hwasan || is_lsan || is_msan || is_tsan || is_ubsan
-}
-
 # compiler ---------------------------------------------------------------------
 #
 # Base compiler configuration.

build/config/sanitizers/BUILD.gn

@@ -6,60 +6,23 @@ import("//build/config/sanitizers/sanitizers.gni")
 
 # Contains the dependencies needed for sanitizers to link into executables and
 # shared_libraries. Unconditionally depend upon this target as it is empty if
-# |is_asan|, |is_lsan|, |is_tsan|, |is_msan| and |use_custom_libcxx| are false.
+# |using_sanitizer| is false.
 group("deps") {
-  deps = [ "//third_party/instrumented_libraries:deps" ]
-  if (is_asan || is_hwasan || is_lsan || is_msan || is_tsan || is_ubsan) {
+  if (using_sanitizer) {
     public_configs = [ ":sanitizer_options_link_helper" ]
-    deps += [ ":options_sources" ]
-  }
-  if (use_custom_libcxx) {
-    deps += [ "//buildtools/third_party/libc++:libcxx_proxy" ]
+    deps = [ ":options_sources" ]
   }
 }
 
 config("sanitizer_options_link_helper") {
   ldflags = [ "-Wl,-u_sanitizer_options_link_helper" ]
-  if (is_asan) {
-    ldflags += [ "-fsanitize=address" ]
-  }
-  if (is_hwasan && is_android && current_cpu == "arm64") {
-    ldflags += [ "-fsanitize=hwaddress" ]
-  }
-  if (is_lsan) {
-    ldflags += [ "-fsanitize=leak" ]
-  }
-  if (is_msan) {
-    ldflags += [ "-fsanitize=memory" ]
-  }
-  if (is_tsan) {
-    ldflags += [ "-fsanitize=thread" ]
-  }
-  if (is_ubsan) {
-    ldflags += [
-      "-fsanitize=undefined",
-      "-fsanitize=float-divide-by-zero",
-      "-fsanitize=float-cast-overflow",
-    ]
-  }
 }
 
 source_set("options_sources") {
   visibility = [
     ":deps",
     "//:gn_visibility",
   ]
+  include_dirs = [ "../../../runtime" ]
   sources = [ "//build/sanitizers/sanitizer_options.cc" ]
-
-  if (is_asan) {
-    sources += [ "//build/sanitizers/asan_suppressions.cc" ]
-  }
-
-  if (is_lsan) {
-    sources += [ "//build/sanitizers/lsan_suppressions.cc" ]
-  }
-
-  if (is_tsan) {
-    sources += [ "//build/sanitizers/tsan_suppressions.cc" ]
-  }
 }