Skip to content

injector logging improvements #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

injector logging improvements #590

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions images/instrumentation/injector/src/root.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,11 +90,7 @@ fn initEnviron() callconv(.C) void {

fn updateStdOsEnviron() !void {
// Dynamic libs do not get the std.os.environ initialized, see https://github.com/ziglang/zig/issues/4524, so we
// back fill it. This logic is based on parsing of envp on zig's start. We re-bind the environment every time, as
// we cannot ensure it did not change since the previous invocation. libc implementations can re-allocate the
// environment (http://github.com/lattera/glibc/blob/master/stdlib/setenv.c;
// https://git.musl-libc.org/cgit/musl/tree/src/env/setenv.c) if the backing memory location is outgrown by apps
// modifying the environment via setenv or putenv.
// back fill it. This logic is based on parsing of envp on zig's start.
if (environ_ptr) |environment_ptr| {
const env_array = environment_ptr.*;
var env_var_count: usize = 0;
Expand Down