test: correctly spell 'txid'

Author: coolaj86

bin/create-memo.js

@@ -49,13 +49,13 @@ async function main() {
 
   let coreUtxo = await require(coinpath);
   let valid =
-    coreUtxo.txId &&
+    coreUtxo.txid &&
     coreUtxo.outputIndex &&
     coreUtxo.satoshis &&
     (coreUtxo.address || coreUtxo.pubKeyHash || coreUtxo.script);
   if (!valid) {
     console.error(
-      "coin JSON must contain 'txId', 'outputIndex', 'satoshis' and one of 'address', 'pubKeyHash', or 'script'",
+      "coin JSON must contain 'txid', 'outputIndex', 'satoshis' and one of 'address', 'pubKeyHash', or 'script'",
     );
     process.exit(1);
     return;

bin/inspect.js

@@ -164,8 +164,8 @@ DashTx._debugPrint = async function (tx) {
     lines.push(`TxID:   N/A`);
   } else if (tx.hasInputScript) {
     lines.push(`Tx Hash: N/A`);
-    let txId = await DashTx.getId(tx.transaction);
-    lines.push(`TxID: ${txId}`);
+    let txid = await DashTx.getId(tx.transaction);
+    lines.push(`TxID: ${txid}`);
     // lines.push(`TxID: 'await Tx.getId(txInfo.transaction)'`);
   } else {
     lines.push(`Tx Hash: N/A`);

tests/hash-and-sign-all.js

@@ -15,7 +15,7 @@ let Secp256k1 = exports.nobleSecp256k1 || require("@dashincubator/secp256k1");
 let rawtx =
   "03000000022b35e8bd64852ae0277a7a4ab6d6293f477f27e859251d27a9a3ebcb5855307f000000006b48304502210098ba308087f7bcc5d9f6c347ffd633422bbbe8d44a20c21a2d5574da35d0a2070220026cae84cec2d96fd4e1a837ab0f3a559fdbd4b19bdd60c4dec450565f79f5f3012103e10848073f3f92f43d718ed1be39afe7314e410eb7080bbc4474e82fe88c5cf2ffffffff2b35e8bd64852ae0277a7a4ab6d6293f477f27e859251d27a9a3ebcb5855307f010000006b483045022100a6ec8b004c6e24047df4a9b2198a42c92862c4b3ad7ac989c85a04ba86fbdb3702200febea2871834d70c1c9d754cbe8163def8f1f721eb8b833098e01bd49ccae65012103e10848073f3f92f43d718ed1be39afe7314e410eb7080bbc4474e82fe88c5cf2ffffffff020a090000000000001976a9145bcd0d776a7252310b9f1a7eee1a749d4212694488ac0a090000000000001976a9145bcd0d776a7252310b9f1a7eee1a749d4212694488ac00000000";
 
-let txId = "7f305558cbeba3a9271d2559e8277f473f29d6b64a7a7a27e02a8564bde8352b";
+let txid = "7f305558cbeba3a9271d2559e8277f473f29d6b64a7a7a27e02a8564bde8352b";
 let prevLockScript = [
   "76", // OP_DUP
   "a9", // OP_HASH160
@@ -44,13 +44,13 @@ let txInfo = {
   version: 3,
   inputs: [
     {
-      txId: txId,
+      txid: txid,
       outputIndex: 0,
       script: prevLockScript,
       sigHashType: sigHashType,
     },
     {
-      txId: txId,
+      txid: txid,
       outputIndex: 1,
       script: prevLockScript,
       sigHashType: sigHashType,

tests/legacy-finalize-presorted.js

@@ -51,8 +51,8 @@ function genTestVals(name, sats, deterministic) {
       {
         address: "XgCLJNfaugnB35WTCMjKQ65GMBN41QtVQJ",
         satoshis: sats,
-        //txId: "ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff",
-        txId: "0123456789abcdeffedcba987654321000112233445566778899aabbccddeeff",
+        //txid: "ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff",
+        txid: "0123456789abcdeffedcba987654321000112233445566778899aabbccddeeff",
         outputIndex: 0,
       },
     ],

tests/lex-sort.js

@@ -23,23 +23,23 @@ function unsort(sorted) {
 
 let inputsSorted = [
   {
-    txId: "00ff",
+    txid: "00ff",
     outputIndex: 0,
   },
   {
-    txId: "00ff",
+    txid: "00ff",
     outputIndex: 9,
   },
   {
-    txId: "aacc",
+    txid: "aacc",
     outputIndex: 5,
   },
   {
-    txId: "ff00",
+    txid: "ff00",
     outputIndex: 0,
   },
   {
-    txId: "ff00",
+    txid: "ff00",
     outputIndex: 9,
   },
 ];
@@ -159,9 +159,9 @@ Zora.test("outputs sort correctly", async function (t) {
 
 Zora.test("legacyCreateTx uses lex sort functions", async function (t) {
   let inputs = [
-    { satoshis: 40500, txId: "ff", outputIndex: 1 },
-    { satoshis: 20500, txId: "00", outputIndex: 2 },
-    { satoshis: 10500, txId: "ff", outputIndex: 0 },
+    { satoshis: 40500, txid: "ff", outputIndex: 1 },
+    { satoshis: 20500, txid: "00", outputIndex: 2 },
+    { satoshis: 10500, txid: "ff", outputIndex: 0 },
   ];
   let sortedIn = inputs.slice(0);
   sortedIn.sort(DashTx.sortInputs);

tests/memo.js

@@ -87,9 +87,9 @@ Zora.test("memo lengths", function (t) {
 Zora.test("can create memo tx", async function (t) {
   let pkh = "82754a9c935fbfcdda5995a32006a68a8156ee2b";
 
-  let txId = "77".repeat(32);
+  let txid = "77".repeat(32);
   let coins = [
-    { pubKeyHash: pkh, satoshis: 20000, txId: txId, outputIndex: 0 },
+    { pubKeyHash: pkh, satoshis: 20000, txid: txid, outputIndex: 0 },
   ];
 
   /** @type {Array<DashTx.TxOutput>} */
@@ -116,12 +116,12 @@ Zora.test("can create memo tx", async function (t) {
 Zora.test("can create donation tx via memo", async function (t) {
   let pkh = "82754a9c935fbfcdda5995a32006a68a8156ee2b";
 
-  let txId = "77".repeat(32);
+  let txid = "77".repeat(32);
   let inputs = [
     {
       pubKeyHash: pkh,
       satoshis: 20000,
-      txId: txId,
+      txid: txid,
       outputIndex: 0,
       sigHashType: DashTx.SIGHASH_ALL,
     },