fix: CGovernanceManager::Clear() should clear all fields

Author: kwvg

src/governance/governance.cpp

@@ -73,11 +73,8 @@ CGovernanceManager::CGovernanceManager(CMasternodeMetaMan& mn_metaman, CNetFulfi
     m_chainman{chainman},
     m_dmnman{dmnman},
     m_mn_sync{mn_sync},
-    nTimeLastDiff(0),
-    nCachedBlockHeight(0),
-    cmapVoteToObject(MAX_CACHE_SIZE),
-    mapPostponedObjects(),
-    fRateChecksEnabled(true),
+    cmapVoteToObject{MAX_CACHE_SIZE},
+    mapPostponedObjects{},
     mapTrigger{}
 {
 }
@@ -1268,14 +1265,22 @@ void GovernanceStore::Clear()
     cmapInvalidVotes.Clear();
     cmmapOrphanVotes.Clear();
     mapLastMasternodeObject.clear();
+    lastMNListForVotingKeys = std::make_shared<CDeterministicMNList>();
 }
 
 void CGovernanceManager::Clear()
 {
     AssertLockNotHeld(cs_store);
     LogPrint(BCLog::GOBJECT, "Governance object manager was cleared\n");
     GovernanceStore::Clear();
+    nTimeLastDiff = 0;
+    nCachedBlockHeight = 0;
     cmapVoteToObject.Clear();
+    mapPostponedObjects.clear();
+    setAdditionalRelayObjects.clear();
+    m_requested_hash_time.clear();
+    fRateChecksEnabled = true;
+    mapTrigger.clear();
 }
 
 std::string GovernanceStore::ToString() const

src/governance/governance.h

@@ -260,14 +260,14 @@ class CGovernanceManager : public GovernanceStore, public GovernanceSignerParent
     const std::unique_ptr<CDeterministicMNManager>& m_dmnman;
     CMasternodeSync& m_mn_sync;
 
-    int64_t nTimeLastDiff;
+    int64_t nTimeLastDiff{0};
     // keep track of current block height
-    int nCachedBlockHeight;
+    int nCachedBlockHeight{0};
     object_ref_cm_t cmapVoteToObject;
     std::map<uint256, std::shared_ptr<CGovernanceObject>> mapPostponedObjects;
     std::set<uint256> setAdditionalRelayObjects;
     std::map<uint256, std::chrono::seconds> m_requested_hash_time;
-    bool fRateChecksEnabled;
+    bool fRateChecksEnabled{true};
     std::map<uint256, std::shared_ptr<CSuperblock>> mapTrigger;
 
     mutable Mutex cs_relay;