Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flag to skip centering in PCA #734

Open
eric-czech opened this issue Sep 3, 2020 · 1 comment · May be fixed by #808
Open

Flag to skip centering in PCA #734

eric-czech opened this issue Sep 3, 2020 · 1 comment · May be fixed by #808

Comments

@eric-czech
Copy link
Contributor

Hey @TomAugspurger, how opposed would you be to introducing small deviations from the scikit-learn interface to PCA like adding a flag in dask-ml.PCA to avoid requiring this centering?

dask-ml/dask_ml/decomposition/pca.py

Lines 270 to 271 in b94c587

self.mean_ = X.mean(0)
X -= self.mean_

That would certainly be a bad default, but if I know that is going to happen downstream from a scaling operation in a pipeline that already does the centering, I would like to have the option to avoid the extra operation. Is that reasonable or are you trying maintain something closer to perfect consistency?
@TomAugspurger
Copy link
Member

Seems reasonable to me!

hristog added a commit to hristog/dask-ml that referenced this issue Mar 20, 2021
@hristog
Introduce a center param to PCA (dask#734)
468862b
hristog added a commit to hristog/dask-ml that referenced this issue Mar 20, 2021
@hristog
Introduce a center param to PCA (dask#734)
f73ce56
@hristog hristog linked a pull request Mar 20, 2021 that will close this issue
Open
hristog added a commit to hristog/dask-ml that referenced this issue Apr 15, 2021
@hristog
Improve docstrings and remove redundant checks (fixes dask#734) (dask…
b2689d3 
…#808)
hristog added a commit to hristog/dask-ml that referenced this issue Apr 20, 2021
@hristog
Make automatic centering in PCA methods optional (fixes dask#734) das…
d241040 
…k#808
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make automatic centering in PCA methods optional hristog/dask-ml
2 participants
@TomAugspurger @eric-czech