Skip to content

Commit eebec4e

Browse files
authored
Merge pull request #78 from data-preservation-programs/fix-signup-button-loading
fix: footer signup form loading state
2 parents 9f0836d + ff24ac5 commit eebec4e

File tree

2 files changed

+38
-3
lines changed

2 files changed

+38
-3
lines changed

README.md

Lines changed: 37 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,44 @@ To build this site:
3737
- Run `npm run dev`
3838
- The site will be available in real time via a localhost URL
3939

40+
### Generate a self-signed certificate
41+
42+
In order to run this repo in local development mode, two files must be added to the repo's root directory. The following set of commands apply to a macOS system. However, if mkcert is installed by another package manager, this can be run on any flavor of *nix.
43+
44+
```bash
45+
cd ~/.ssh
46+
brew install mkcert # replace with another package manager for linux distro
47+
brew install nss # need to install certutil before running `mkcert -install` so the CA can be automatically installed in Firefox
48+
49+
# at this point, open any https website in Firefox before running the below commands
50+
51+
mkcert -install
52+
mkcert -key-file localhost_key.pem -cert-file localhost_cert.pem localhost 127.0.0.1
53+
cat localhost_cert.pem > localhost_fullchain.pem
54+
cat "$(mkcert -CAROOT)/rootCA.pem" >> localhost_fullchain.pem
55+
```
56+
57+
Now, navigate to your project directory, wherever the repo was cloned to, for example cd `~/Sites/work/website` and copy the `.pem` files into the repo root. These keys are .gitignored by default.
58+
59+
Or run the below command to copy the files to your currently `cd`’d dir automatically
60+
61+
```bash
62+
cp -v ~/.ssh/localhost_cert.pem ~/.ssh/localhost_key.pem .
63+
```
64+
65+
### Environment variables
66+
67+
Add the following `.env` file to the repo root
68+
69+
```ini
70+
NODE_ENV=development
71+
SERVER_ENV=development
72+
AIRTABLE_SINGULARITY_ACCESS_TOKEN=<temp>
73+
```
74+
4075
## Updating dependencies
4176

42-
Please use `npm ci` in place of `npm i` when not explicitly upgrading dependencies. `npm ci` will only install versions of packages provided in the lockfile, leading to more stability.
77+
Please use `npm ci` in place of `npm i` when not explicitly upgrading dependencies. `npm ci` will only install versions of packages provided in the lockfile, leading to more stability.
4378

4479
Always regression test the site if upgrading packages, as they may contain breaking changes.
4580

@@ -82,6 +117,6 @@ To better display the components available on the site, their properties, and th
82117

83118
## [Release Please](https://github.com/googleapis/release-please)
84119

85-
- Release Please automates CHANGELOG generation, the creation of GitHub releases, and version bumps for your projects.
120+
- Release Please automates CHANGELOG generation, the creation of GitHub releases, and version bumps for your projects.
86121
- It is currently setup as a github action in this repo
87122
- See [documentation](https://github.com/googleapis/release-please) on how to use

components/subfooter-form.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ const submitForm = async () => {
130130
} else {
131131
fieldError.value = true
132132
}
133-
buttonStore.set({id: 'subfooter-card-newsletter-signup', loading: false})
133+
buttonStore.setButton({id: 'subfooter-card-newsletter-signup', loading: false})
134134
}
135135
136136
</script>

0 commit comments

Comments
 (0)