Skip to content

Commit 9026f37

Browse files
committed
Fix telemetry feature flag tests to set mock session host
The tests were failing because they called get_telemetry_client("test") but the mock session didn't have .host set, so the telemetry client was registered under a different key (likely None or MagicMock). This caused the factory to return NoopTelemetryClient instead of the expected client. Fixed by setting mock_session_instance.host = "test" in all three tests.
1 parent 01ea1e1 commit 9026f37

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

tests/unit/test_telemetry.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -391,6 +391,7 @@ def test_telemetry_enabled_when_flag_is_true(self, mock_http_request, MockSessio
391391
self._mock_ff_response(mock_http_request, enabled=True)
392392
mock_session_instance = MockSession.return_value
393393
mock_session_instance.guid_hex = "test-session-ff-true"
394+
mock_session_instance.host = "test" # Set host for telemetry client lookup
394395
mock_session_instance.auth_provider = AccessTokenAuthProvider("token")
395396
mock_session_instance.is_open = (
396397
False # Connection starts closed for test cleanup
@@ -421,6 +422,7 @@ def test_telemetry_disabled_when_flag_is_false(
421422
self._mock_ff_response(mock_http_request, enabled=False)
422423
mock_session_instance = MockSession.return_value
423424
mock_session_instance.guid_hex = "test-session-ff-false"
425+
mock_session_instance.host = "test" # Set host for telemetry client lookup
424426
mock_session_instance.auth_provider = AccessTokenAuthProvider("token")
425427
mock_session_instance.is_open = (
426428
False # Connection starts closed for test cleanup
@@ -451,6 +453,7 @@ def test_telemetry_disabled_when_flag_request_fails(
451453
mock_http_request.side_effect = Exception("Network is down")
452454
mock_session_instance = MockSession.return_value
453455
mock_session_instance.guid_hex = "test-session-ff-fail"
456+
mock_session_instance.host = "test" # Set host for telemetry client lookup
454457
mock_session_instance.auth_provider = AccessTokenAuthProvider("token")
455458
mock_session_instance.is_open = (
456459
False # Connection starts closed for test cleanup

0 commit comments

Comments
 (0)