Skip to content

Commit a25e3f3

Browse files
committed
fixed linting issue
Signed-off-by: Nikhil Suri <[email protected]>
1 parent 05b9aa0 commit a25e3f3

File tree

4 files changed

+98
-52
lines changed

4 files changed

+98
-52
lines changed

src/databricks/sql/client.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -320,7 +320,9 @@ def read(self) -> Optional[OAuthToken]:
320320
)
321321

322322
self.force_enable_telemetry = kwargs.get("force_enable_telemetry", False)
323-
self.enable_telemetry = kwargs.get("enable_telemetry", True) # Default to True for telemetry
323+
self.enable_telemetry = kwargs.get(
324+
"enable_telemetry", True
325+
) # Default to True for telemetry
324326
self.telemetry_enabled = TelemetryHelper.is_telemetry_enabled(self)
325327

326328
TelemetryClientFactory.initialize_telemetry_client(

src/databricks/sql/common/feature_flag.py

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -107,8 +107,9 @@ def get_flag_value(self, name: str, default_value: Any) -> Any:
107107
def _refresh_flags(self):
108108
"""Performs a synchronous network request to fetch and update flags."""
109109
import logging
110+
110111
logger = logging.getLogger(__name__)
111-
112+
112113
headers = {}
113114
try:
114115
# Authenticate the request
@@ -130,13 +131,17 @@ def _refresh_flags(self):
130131
logger.info(f"Feature flags loaded: {self._flags}")
131132
else:
132133
# On failure, initialize with an empty dictionary to prevent re-blocking.
133-
logger.info(f"Feature flag fetch failed with status {response.status}, initializing empty flags")
134+
logger.info(
135+
f"Feature flag fetch failed with status {response.status}, initializing empty flags"
136+
)
134137
if self._flags is None:
135138
self._flags = {}
136139

137140
except Exception as e:
138141
# On exception, initialize with an empty dictionary to prevent re-blocking.
139-
logger.info(f"Feature flag fetch exception: {type(e).__name__}: {e}, initializing empty flags")
142+
logger.info(
143+
f"Feature flag fetch exception: {type(e).__name__}: {e}, initializing empty flags"
144+
)
140145
if self._flags is None:
141146
self._flags = {}
142147

src/databricks/sql/telemetry/telemetry_client.py

Lines changed: 18 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,9 @@ def is_telemetry_enabled(connection: "Connection") -> bool:
114114
return True
115115

116116
if connection.enable_telemetry:
117-
logger.info(f"Telemetry: enable_telemetry=True, checking feature flag: {TelemetryHelper.TELEMETRY_FEATURE_FLAG_NAME}")
117+
logger.info(
118+
f"Telemetry: enable_telemetry=True, checking feature flag: {TelemetryHelper.TELEMETRY_FEATURE_FLAG_NAME}"
119+
)
118120
context = FeatureFlagsContextFactory.get_instance(connection)
119121
flag_value = context.get_flag_value(
120122
TelemetryHelper.TELEMETRY_FEATURE_FLAG_NAME, default_value=False
@@ -200,7 +202,9 @@ def _export_event(self, event):
200202
logger.info(f"Exporting telemetry event for connection {self._session_id_hex}")
201203
with self._lock:
202204
self._events_batch.append(event)
203-
logger.info(f"Event added to batch, batch size now: {len(self._events_batch)}/{self._batch_size}")
205+
logger.info(
206+
f"Event added to batch, batch size now: {len(self._events_batch)}/{self._batch_size}"
207+
)
204208
if len(self._events_batch) >= self._batch_size:
205209
logger.info(f"Batch size reached ({self._batch_size}), flushing events")
206210
self._flush()
@@ -485,17 +489,25 @@ def initialize_telemetry_client(
485489
batch_size=batch_size,
486490
client_context=client_context,
487491
)
488-
logger.info(f"Created TelemetryClient for connection {session_id_hex}")
492+
logger.info(
493+
f"Created TelemetryClient for connection {session_id_hex}"
494+
)
489495
else:
490496
TelemetryClientFactory._clients[
491497
session_id_hex
492498
] = NoopTelemetryClient()
493-
logger.info(f"Created NoopTelemetryClient for connection {session_id_hex}")
499+
logger.info(
500+
f"Created NoopTelemetryClient for connection {session_id_hex}"
501+
)
494502
except Exception as e:
495-
logger.info(f"Failed to initialize telemetry client: {type(e).__name__}: {e}")
503+
logger.info(
504+
f"Failed to initialize telemetry client: {type(e).__name__}: {e}"
505+
)
496506
# Fallback to NoopTelemetryClient to ensure connection doesn't fail
497507
TelemetryClientFactory._clients[session_id_hex] = NoopTelemetryClient()
498-
logger.info(f"Fallback to NoopTelemetryClient for connection {session_id_hex}")
508+
logger.info(
509+
f"Fallback to NoopTelemetryClient for connection {session_id_hex}"
510+
)
499511

500512
@staticmethod
501513
def get_telemetry_client(session_id_hex):

0 commit comments

Comments
 (0)