Skip to content

Conversation

@m-abulazm
Copy link
Contributor

@m-abulazm m-abulazm commented Nov 20, 2025

Changes

What does this PR do?

Add prompts during configure-reconcile for the data sources' credentials. this allows users to use local, env or databricks secrets.
this is more flexible and secure than the current approach that requires users to create a secret specifically for reconcile and now users can reuse their existing secrets.

Also allows reconcile to support new vault types e.g. azure, google secrets as we implement more supported backends in the future

Linked issues

Progresses #1008, #2123, #2159

Functionality

  • added relevant user documentation
  • modified existing command: databricks labs lakebridge configure-reconcile

Tests

  • manually tested
  • added unit tests
  • added integration tests

@m-abulazm m-abulazm self-assigned this Nov 20, 2025
@m-abulazm m-abulazm requested a review from a team as a code owner November 20, 2025 15:36
@m-abulazm m-abulazm added feat/cli actions that are visible to the user feat/recon making sure that remorphed query produces the same results as original stacked PR Should be reviewed, but not merged labels Nov 20, 2025
@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

❌ Patch coverage is 90.74074% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.13%. Comparing base (75611fb) to head (b79b760).

Files with missing lines Patch % Lines
...icks/labs/lakebridge/helpers/recon_config_utils.py 93.75% 1 Missing and 2 partials ⚠️
src/databricks/labs/lakebridge/install.py 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           refactor/creds-manager    #2157      +/-   ##
==========================================================
- Coverage                   65.37%   65.13%   -0.24%     
==========================================================
  Files                         100      100              
  Lines                        8536     8490      -46     
  Branches                      876      874       -2     
==========================================================
- Hits                         5580     5530      -50     
- Misses                       2769     2771       +2     
- Partials                      187      189       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Nov 20, 2025

✅ 51/51 passed, 10 flaky, 3m33s total

Flaky tests:

  • 🤪 test_validate_non_empty_tables (8ms)
  • 🤪 test_validate_invalid_source_tech (166ms)
  • 🤪 test_validate_table_not_found (1ms)
  • 🤪 test_validate_successful_schema_check (303ms)
  • 🤪 test_validate_invalid_schema_check (1ms)
  • 🤪 test_transpiles_informatica_to_sparksql_non_interactive[False] (19.989s)
  • 🤪 test_transpiles_informatica_to_sparksql (20.294s)
  • 🤪 test_transpile_teradata_sql_non_interactive[True] (8.547s)
  • 🤪 test_transpile_teradata_sql_non_interactive[False] (4.777s)
  • 🤪 test_transpiles_informatica_to_sparksql_non_interactive[True] (11.156s)

Running from acceptance #3053

@m-abulazm m-abulazm added the documentation Improvements or additions to documentation label Nov 21, 2025
# Conflicts:
#	src/databricks/labs/lakebridge/install.py
#	tests/unit/test_install.py
Copy link
Collaborator

@gueniai gueniai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation feat/cli actions that are visible to the user feat/recon making sure that remorphed query produces the same results as original stacked PR Should be reviewed, but not merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants