-
Notifications
You must be signed in to change notification settings - Fork 48
Expand file tree
/
Copy pathfind_entities.go
More file actions
451 lines (406 loc) · 12 KB
/
find_entities.go
File metadata and controls
451 lines (406 loc) · 12 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
// Copyright 2022 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// https://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
// Package recon contains code for recon.
package recon
import (
"context"
"fmt"
"sort"
"strings"
internalmaps "github.com/datacommonsorg/mixer/internal/maps"
pb "github.com/datacommonsorg/mixer/internal/proto"
pbv1 "github.com/datacommonsorg/mixer/internal/proto/v1"
"github.com/datacommonsorg/mixer/internal/server/v1/propertyvalues"
"github.com/datacommonsorg/mixer/internal/store"
"github.com/datacommonsorg/mixer/internal/util"
"golang.org/x/sync/errgroup"
"googlemaps.github.io/maps"
)
const (
maxNumEntitiesPerRequest = 5000
maxMapsAPICallsInParallel = 25
)
type entityInfo struct {
description string
typeOf string
}
// BulkFindEntities implements API for Mixer.BulkFindEntities.
func BulkFindEntities(
ctx context.Context,
in *pb.BulkFindEntitiesRequest,
store *store.Store,
mapsClient internalmaps.MapsClient,
) (*pb.BulkFindEntitiesResponse, error) {
if l := len(in.GetEntities()); l == 0 {
return nil, fmt.Errorf("empty input")
} else if l > maxNumEntitiesPerRequest {
return nil, fmt.Errorf(
"exceeded max number of entities per request (%d): %d",
maxNumEntitiesPerRequest, l)
}
// Load input.
entityInfoSet := map[entityInfo]struct{}{}
for _, entity := range in.GetEntities() {
description := entity.GetDescription()
if description == "" {
continue
}
entityInfoSet[entityInfo{description, entity.GetType()}] = struct{}{}
}
// Get DCIDs.
entityInfoToDCIDs, dcidSet, err := resolveDCIDs(
ctx, mapsClient, store, entityInfoSet)
if err != nil {
return nil, err
}
// Get types of the DCIDs.
dcidToTypeSet, err := getPlaceTypes(ctx, dcidSet, store)
if err != nil {
return nil, err
}
// Assemble results.
resp := &pb.BulkFindEntitiesResponse{}
for entityInfo, dcids := range entityInfoToDCIDs {
entity := &pb.BulkFindEntitiesResponse_Entity{
Description: entityInfo.description,
Type: entityInfo.typeOf,
}
if len(dcids) != 0 {
if entityInfo.typeOf == "" {
// No type filtering.
entity.Dcids = dcids
} else {
// Type filtering.
filteredDCIDs := []string{}
for _, dcid := range dcids {
typeSet, ok := dcidToTypeSet[dcid]
if !ok {
continue
}
if _, ok := typeSet[entityInfo.typeOf]; ok {
filteredDCIDs = append(filteredDCIDs, dcid)
}
}
entity.Dcids = filteredDCIDs
}
}
resp.Entities = append(resp.Entities, entity)
}
// Sort to make results determistic.
sort.Slice(resp.Entities, func(i, j int) bool {
if resp.Entities[i].GetDescription() == resp.Entities[j].GetDescription() {
return resp.Entities[i].GetType() < resp.Entities[j].GetType()
}
return resp.Entities[i].GetDescription() < resp.Entities[j].GetDescription()
})
return resp, nil
}
// TODO(ws):
//
// Set some debug info so we can tell how we matched (RecognizePlaces vs Maps API).
//
// Consider calling both, if both have results, prefer RecognizePlaces,
// but use Maps API as signal to reorder the results.
func resolveDCIDs(
ctx context.Context,
mapsClient internalmaps.MapsClient,
store *store.Store,
entityInfoSet map[entityInfo]struct{},
) (
map[entityInfo][]string, /* entityInfo -> [DCID] */
map[string]struct{}, /* [DCID] for all entities */
error,
) {
// First try to resolve DCIDs by RecognizePlaces.
entityInfoToDCIDs, dcidSet, err := resolveWithRecognizePlaces(
ctx, store, entityInfoSet)
if err != nil {
return nil, nil, err
}
// See if there are any entities that cannot be resolved by RecognizePlaces.
missingEntityInfoSet := map[entityInfo]struct{}{}
for entityInfo := range entityInfoSet {
if dcids, ok := entityInfoToDCIDs[entityInfo]; !ok || len(dcids) == 0 {
missingEntityInfoSet[entityInfo] = struct{}{}
}
}
if len(missingEntityInfoSet) > 0 {
// For entities that cannot be resolved by RecognizePlaces, try Maps API.
missingEntityInfoToDCIDSet, missingDcidSet, err := resolveWithMapsAPI(
ctx, mapsClient, store, missingEntityInfoSet)
if err != nil {
return nil, nil, err
}
// Add the newly resolved entities.
for e, dSet := range missingEntityInfoToDCIDSet {
for dcid := range dSet {
entityInfoToDCIDs[e] = append(entityInfoToDCIDs[e], dcid)
}
}
for dcid := range missingDcidSet {
dcidSet[dcid] = struct{}{}
}
}
// Format the result, transform DCID set to DCID list.
res := map[entityInfo][]string{}
for e, dcids := range entityInfoToDCIDs {
res[e] = append(res[e], dcids...)
}
return res, dcidSet, nil
}
func resolveWithRecognizePlaces(
ctx context.Context,
store *store.Store,
entityInfoSet map[entityInfo]struct{},
) (
map[entityInfo][]string, /* entityInfo -> [DCID] */
map[string]struct{}, /* DCID set for all entities */
error,
) {
// Check if the query fully matches any place names.
// NOTE: names also include "selfName containingPlaceName", e.g. "Brussels Belgium".
hasQueryNameMatch := func(dcid, query string) bool {
format := func(n string) string {
s := strings.ReplaceAll(strings.ToLower(n), " ", "")
return strings.ReplaceAll(s, ",", "")
}
names, ok := store.RecogPlaceStore.DcidToNames[dcid]
if !ok {
return false
}
for _, name := range names {
if format(query) == format(name) {
return true
}
}
return false
}
req := &pb.RecognizePlacesRequest{
Queries: []string{},
}
descriptionToType := map[string]string{}
for e := range entityInfoSet {
req.Queries = append(req.Queries, e.description)
descriptionToType[e.description] = e.typeOf
}
resp, err := RecognizePlaces(ctx, req, store, true)
if err != nil {
return nil, nil, err
}
entityInfoToDCIDs := map[entityInfo][]string{}
dcidSet := map[string]struct{}{}
for query, items := range resp.GetQueryItems() {
e := entityInfo{description: query, typeOf: descriptionToType[query]}
entityInfoToDCIDs[e] = []string{}
for _, item := range items.GetItems() {
for _, place := range item.GetPlaces() {
dcid := place.GetDcid()
if hasQueryNameMatch(dcid, query) {
entityInfoToDCIDs[e] = append(entityInfoToDCIDs[e], dcid)
dcidSet[dcid] = struct{}{}
}
}
}
}
return entityInfoToDCIDs, dcidSet, nil
}
func resolveWithMapsAPI(
ctx context.Context,
mapsClient internalmaps.MapsClient,
store *store.Store,
entityInfoSet map[entityInfo]struct{},
) (
map[entityInfo]map[string]struct{}, /* entityInfo -> DCID set */
map[string]struct{}, /* [DCID] for all entities */
error,
) {
// Get place IDs.
entityInfoToPlaceIDs, placeIDSet, err := resolvePlaceIDsFromDescriptions(
ctx, mapsClient, entityInfoSet)
if err != nil {
return nil, nil, err
}
if len(placeIDSet) == 0 {
return map[entityInfo]map[string]struct{}{}, map[string]struct{}{}, nil
}
// Resolve place IDs to get DCIDs.
placeIDToDCIDs, dcidSet, err := resolveDCIDsFromPlaceIDs(ctx, placeIDSet, store)
if err != nil {
return nil, nil, err
}
res := map[entityInfo]map[string]struct{}{}
for entityInfo, placeIDs := range entityInfoToPlaceIDs {
if _, ok := res[entityInfo]; !ok {
res[entityInfo] = map[string]struct{}{}
}
for _, placeID := range placeIDs {
if dcids, ok := placeIDToDCIDs[placeID]; ok {
for _, dcid := range dcids {
res[entityInfo][dcid] = struct{}{}
}
}
}
}
return res, dcidSet, nil
}
func resolvePlaceIDsFromDescriptions(
ctx context.Context,
mapsClient internalmaps.MapsClient,
entityInfoSet map[entityInfo]struct{},
) (
map[entityInfo][]string, /* entityInfo -> [place ID] */
map[string]struct{}, /* [place ID] for all entities */
error,
) {
type resolveResult struct {
entityInfo *entityInfo
placeIDs []string
}
// Distribute entityInfoSet to maxMapsAPICallsInParallel shards for parallel processing.
entityInfoListShards := make([][]entityInfo, maxMapsAPICallsInParallel)
idx := 0
for entityInfo := range entityInfoSet {
entityInfoListShards[idx] = append(entityInfoListShards[idx], entityInfo)
idx++
if idx >= maxMapsAPICallsInParallel {
idx = 0
}
}
// The channel to receive results from parallel workers.
resolveResultChan := make(chan resolveResult, len(entityInfoSet))
// Worker function.
mapsAPICallWorkerFunc := func(ctx context.Context, i int) func() error {
return func() error {
for _, entityInfo := range entityInfoListShards[i] {
placeIDs, err := findPlaceIDsForEntity(ctx, mapsClient, &entityInfo)
if err != nil {
return err
}
usedPlaceIds := []string{}
if len(placeIDs) > 0 {
// Only keep the first place ID, as the rest ones are usually much less accurate.
usedPlaceIds = []string{placeIDs[0]}
}
resolveResultChan <- resolveResult{
entityInfo: &entityInfo,
placeIDs: usedPlaceIds}
}
return nil
}
}
// Call Maps API to find place IDs in parallel.
// The errors in the Goroutines need to be captured, so we use errgroup.
eg, errCtx := errgroup.WithContext(ctx)
for i := 0; i < maxMapsAPICallsInParallel; i++ {
eg.Go(mapsAPICallWorkerFunc(errCtx, i))
}
if err := eg.Wait(); err != nil {
return nil, nil, err
}
close(resolveResultChan)
// Read out the results sent by workers.
entityInfoToPlaceIDs := map[entityInfo][]string{}
placeIDSet := map[string]struct{}{}
for res := range resolveResultChan {
entityInfoToPlaceIDs[*res.entityInfo] = res.placeIDs
for _, placeID := range res.placeIDs {
placeIDSet[placeID] = struct{}{}
}
}
return entityInfoToPlaceIDs, placeIDSet, nil
}
func findPlaceIDsForEntity(
ctx context.Context,
mapsClient internalmaps.MapsClient,
entityInfo *entityInfo,
) ([]string, error) {
// When type is supplied, we append it to the description to increase the accuracy.
input := entityInfo.description
if t := entityInfo.typeOf; t != "" {
input += (" " + t)
}
resp, err := mapsClient.FindPlaceFromText(ctx, &maps.FindPlaceFromTextRequest{
Input: input,
InputType: maps.FindPlaceFromTextInputTypeTextQuery,
Fields: []maps.PlaceSearchFieldMask{maps.PlaceSearchFieldMaskPlaceID},
})
if err != nil {
return nil, err
}
placeIDs := []string{}
for _, candidate := range resp.Candidates {
placeIDs = append(placeIDs, candidate.PlaceID)
}
return placeIDs, nil
}
func resolveDCIDsFromPlaceIDs(
ctx context.Context,
placeIDSet map[string]struct{},
store *store.Store,
) (
map[string][]string, /* Place ID -> [DCID] */
map[string]struct{}, /* [DCID] for all place IDs */
error,
) {
resolveResp, err := ResolveIds(ctx,
&pb.ResolveIdsRequest{
InProp: "placeId",
OutProp: "dcid",
Ids: util.StringSetToSlice(placeIDSet),
},
store)
if err != nil {
return nil, nil, err
}
placeIDToDCIDs := map[string][]string{}
dcidSet := map[string]struct{}{}
for _, entity := range resolveResp.GetEntities() {
dcids := entity.GetOutIds()
// Sort to make the result deterministic.
sort.Strings(dcids)
placeIDToDCIDs[entity.GetInId()] = append(placeIDToDCIDs[entity.GetInId()],
dcids...)
for _, dcid := range dcids {
dcidSet[dcid] = struct{}{}
}
}
return placeIDToDCIDs, dcidSet, nil
}
func getPlaceTypes(
ctx context.Context,
dcidSet map[string]struct{},
store *store.Store,
) (
map[string]map[string]struct{}, /* DCID -> {type} */
error,
) {
resp, err := propertyvalues.BulkPropertyValues(ctx,
&pbv1.BulkPropertyValuesRequest{
Property: "typeOf",
Nodes: util.StringSetToSlice(dcidSet),
Direction: util.DirectionOut,
},
store)
if err != nil {
return nil, err
}
dcidToTypeSet := map[string]map[string]struct{}{}
for _, nodeInfo := range resp.GetData() {
dcidToTypeSet[nodeInfo.GetNode()] = map[string]struct{}{}
for _, entityInfo := range nodeInfo.GetValues() {
dcidToTypeSet[nodeInfo.GetNode()][entityInfo.GetDcid()] = struct{}{}
}
}
return dcidToTypeSet, nil
}