-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
completeness of implementation? #11
Comments
Hey @adriangb, so far the After finishing up the integration test I plan to port the query rewriting code to that empty file you mentioned. |
The implementation is here: https://github.com/JanKaul/iceberg-rust/tree/main/datafusion_iceberg%2Fsrc%2Fmaterialized_view I have to update the documentation and upload the slides somewhere. |
Perhaps you can post the slides to |
Hey @alamb @JanKaul, sorry I've been traveling the last two weeks and I didn't see your comments. (I can't seem to figure out how to get notifications for this repo 😞) I think collaboration is a great idea. I would note that I think the materialized view implementations differ in some key ways:
I think it would be interesting if we could house both IVM implementations and put them behind a unified interface, then hook it up so that users could refresh their tables through SQL commands. This would provide a great out-of-the-box experience for materialized views in DataFusion, and it would let us use the query rewriting implementation for any kind of materialized view. Another thing we could try to do is abstract the storage layer, and have each IVM implementation list which storage operations it needs (insert, delete, overwrite partition, full overwrite, read from snapshot/time travel?). Then each IVM implementation can work regardless of the storage backend, as long as their respective operations are supported. |
hi @suremarc, I was wondering if the implementation here is complete? I was trying to grok it and came across e.g. https://github.com/datafusion-contrib/datafusion-materialized-views/blob/main/src/rewrite.rs which seems to be an empty file. I wanted to confirm what the state of the repo is before I break my brain. Thanks for your work on this!
The text was updated successfully, but these errors were encountered: