Skip to content

Commit 5d047ae

Browse files
finish fixing lint for cc--ch-555-remove-modules
1 parent fe69d57 commit 5d047ae

File tree

2 files changed

+22
-27
lines changed

2 files changed

+22
-27
lines changed

datahub-web-react/src/app/homeV3/context/hooks/useModuleOperations.ts

Lines changed: 21 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { message } from 'antd';
2-
import { useCallback } from 'react';
2+
import { useCallback, useMemo } from 'react';
33

44
import { ModulePositionInput } from '@app/homeV3/template/types';
55

@@ -149,14 +149,24 @@ export function useModuleOperations(
149149
const [upsertPageModuleMutation] = useUpsertPageModuleMutation();
150150

151151
// Create context object to avoid passing many parameters
152-
const context: TemplateUpdateContext = {
153-
isEditingGlobalTemplate,
154-
personalTemplate,
155-
globalTemplate,
156-
setPersonalTemplate,
157-
setGlobalTemplate,
158-
upsertTemplate,
159-
};
152+
const context: TemplateUpdateContext = useMemo(
153+
() => ({
154+
isEditingGlobalTemplate,
155+
personalTemplate,
156+
globalTemplate,
157+
setPersonalTemplate,
158+
setGlobalTemplate,
159+
upsertTemplate,
160+
}),
161+
[
162+
isEditingGlobalTemplate,
163+
personalTemplate,
164+
globalTemplate,
165+
setPersonalTemplate,
166+
setGlobalTemplate,
167+
upsertTemplate,
168+
],
169+
);
160170

161171
// Updates template state with a new module and updates the appropriate template on the backend
162172
const addModule = useCallback(
@@ -187,15 +197,7 @@ export function useModuleOperations(
187197
// Persist changes
188198
persistTemplateChanges(context, updatedTemplate, isPersonal, 'add module');
189199
},
190-
[
191-
isEditingGlobalTemplate,
192-
personalTemplate,
193-
globalTemplate,
194-
setPersonalTemplate,
195-
setGlobalTemplate,
196-
upsertTemplate,
197-
updateTemplateWithModule,
198-
],
200+
[context, updateTemplateWithModule],
199201
);
200202

201203
// Removes a module from the template state and updates the appropriate template on the backend
@@ -227,15 +229,7 @@ export function useModuleOperations(
227229
// Persist changes
228230
persistTemplateChanges(context, updatedTemplate, isPersonal, 'remove module');
229231
},
230-
[
231-
isEditingGlobalTemplate,
232-
personalTemplate,
233-
globalTemplate,
234-
setPersonalTemplate,
235-
setGlobalTemplate,
236-
upsertTemplate,
237-
removeModuleFromTemplate,
238-
],
232+
[context, removeModuleFromTemplate],
239233
);
240234

241235
// Takes input and makes a call to create a module then add that module to the template

datahub-web-react/src/app/homeV3/module/components/__tests__/LargeModule.test.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@ describe('LargeModule', () => {
8080
const defaultProps = {
8181
module: mockModule,
8282
children: <div data-testid="module-content">Module Content</div>,
83+
position: { rowIndex: 0, moduleIndex: 0 },
8384
};
8485

8586
it('should render the module with correct name', () => {

0 commit comments

Comments
 (0)