Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out webpack-stats.json #360

Closed
smcalilly opened this issue Feb 21, 2024 · 2 comments
Closed

Figure out webpack-stats.json #360

smcalilly opened this issue Feb 21, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@smcalilly
Copy link
Contributor

Description

Is webpack-stats.json supposed to be committed to version control or not?

Docs say no.

Our experience says otherwise.

We need to configure our setup so we don't need this file in version control.

@smcalilly smcalilly added the bug Something isn't working label Feb 21, 2024
@hancush
Copy link
Member

hancush commented Sep 19, 2024

django-webpack-loader requires us to specify where the webpack-stats.json file lives, and complains if it doesn't exist (e.g., at build time if we haven't committed that file to version control). https://github.com/django-webpack/django-webpack-loader?tab=readme-ov-file#configuring-the-django-settings-file

to circumvent this, we can use the dummy loader they provide in our tests: https://github.com/django-webpack/django-webpack-loader?tab=readme-ov-file#using-in-tests

@antidipyramid
Copy link
Contributor

Will be handled in #371

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants