Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][worker]服务配置的required设置为false不会写入配置文件 #607

Open
3 tasks done
blackflash997997 opened this issue Aug 23, 2024 · 0 comments
Open
3 tasks done
Labels
bug Something isn't working

Comments

@blackflash997997
Copy link
Contributor

Search before asking

  • I had searched in the issues and found no similar issues.

What happened

service_ddl.json中parameters的配置项如果required属性为false,那么安装服务的时候不会写入对应的配置文件

What you expected to happen

required属性应为界面的必填项,required为true时必须填写,required为false非必填,但是也应该一起写入配置文件,而且如果所有配置的required都为true也容易引起混淆,让使用者无法知道哪些参数是重要的

How to reproduce

1.服务的service_ddl.json中增加一项配置,required设置为false
2.在generators的includeParams中增加上述配置名。
3.安装服务,查看generators对应的filename配置文件中该配置是否正常写入

Anything else

No response

Version

dev

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@blackflash997997 blackflash997997 added the bug Something isn't working label Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant