Skip to content

Commit d328ea0

Browse files
committed
fix: update test dependencies installation for different React versions in CI/Docker
1 parent e99d4a5 commit d328ea0

File tree

2 files changed

+13
-4
lines changed

2 files changed

+13
-4
lines changed

.github/workflows/test.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,11 @@ jobs:
3434
- name: Install React and testing libraries for React ${{ matrix.react-version }}
3535
run: |
3636
if [[ "${{ matrix.react-version }}" == "16.8.0" || "${{ matrix.react-version }}" == "17.0.0" ]]; then
37-
npm install --force react@^${{ matrix.react-version }} react-dom@^${{ matrix.react-version }} @types/react@^${{ matrix.react-version }} @types/react-dom@^${{ matrix.react-version }} @testing-library/react@^12.1.5 @testing-library/react-hooks@^8.0.1
37+
npm install react@^${{ matrix.react-version }} react-dom@^${{ matrix.react-version }} @types/react@^${{ matrix.react-version }} @types/react-dom@^${{ matrix.react-version }} @testing-library/react@^12.1.5 @testing-library/react-hooks@^8.0.1
38+
elif [[ "${{ matrix.react-version }}" == "18.0.0" ]]; then
39+
npm install react@^${{ matrix.react-version }} react-dom@^${{ matrix.react-version }} @types/react@^${{ matrix.react-version }} @types/react-dom@^${{ matrix.react-version }} @testing-library/react@^14.1.0
3840
else
39-
npm install --force react@^${{ matrix.react-version }} react-dom@^${{ matrix.react-version }} @types/react@^${{ matrix.react-version }} @types/react-dom@^${{ matrix.react-version }} @testing-library/react@^14.1.0
41+
npm install react@^${{ matrix.react-version }} react-dom@^${{ matrix.react-version }} @types/react@^${{ matrix.react-version }} @types/react-dom@^${{ matrix.react-version }} @testing-library/react@^16.1.0
4042
fi
4143
4244
- name: Run tests

Dockerfile.test

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ COPY package.json package-lock.json ./
99

1010
RUN npm ci
1111

12-
# Conditionally install react-hooks for older React versions
12+
# Conditionally install testing libraries based on React version
1313
RUN if [ "${REACT_VERSION}" = "16.8.0" ] || [ "${REACT_VERSION}" = "17.0.0" ]; then \
1414
npm install \
1515
"react@${REACT_VERSION}" \
@@ -18,13 +18,20 @@ RUN if [ "${REACT_VERSION}" = "16.8.0" ] || [ "${REACT_VERSION}" = "17.0.0" ]; t
1818
"@types/react-dom@${REACT_VERSION}" \
1919
"@testing-library/react@^12.1.5" \
2020
"@testing-library/react-hooks@^8.0.1"; \
21-
else \
21+
elif [ "${REACT_VERSION}" = "18.0.0" ]; then \
2222
npm install \
2323
"react@${REACT_VERSION}" \
2424
"react-dom@${REACT_VERSION}" \
2525
"@types/react@${REACT_VERSION}" \
2626
"@types/react-dom@${REACT_VERSION}" \
2727
"@testing-library/react@^14.1.0"; \
28+
else \
29+
npm install \
30+
"react@${REACT_VERSION}" \
31+
"react-dom@${REACT_VERSION}" \
32+
"@types/react@${REACT_VERSION}" \
33+
"@types/react-dom@${REACT_VERSION}" \
34+
"@testing-library/react@^16.1.0"; \
2835
fi
2936

3037
COPY . .

0 commit comments

Comments
 (0)