Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patrick 0.1.0 will have backwards incompatible changes #27

Open
michaelquinn32 opened this issue Oct 7, 2021 · 1 comment · May be fixed by #32
Open

Patrick 0.1.0 will have backwards incompatible changes #27

michaelquinn32 opened this issue Oct 7, 2021 · 1 comment · May be fixed by #32

Comments

@michaelquinn32
Copy link

Hi David!

Thanks for using patrick for creating parameterized tests.

I am going to start the process of releasing a backwards incompatible change in the package.

  • In the past, the undocumented test_name parameter could be used to in cases data frames and as an argument for naming tests
  • I am moving this to a documented argument in with_parameters_test_that(). The argument is also getting the name .test_name in order to distinguish it from test cases passed by a user

In version 0.1.0, patrick will throw a warning about this change and rename input as appropriate. In the future, this warning will be dropped. Addressing it requires changing your use of test_name to .test_name.

Apologies for any inconvenience that this causes. Please let me know how else I can help.

Best wishes,
Michael
@michaelquinn32
Copy link
Author

Friendly ping. I'm looking to drop the support for using test_name to prefer .test_name instead.

Do you mind updating your package?

Thanks!

@michaelquinn32 michaelquinn32 linked a pull request Jan 19, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace deprecated use of test_name. michaelquinn32/mombf
1 participant
@michaelquinn32