Skip to content

Inline step backoff rate and interval options are misused #254

@youribonnaffe

Description

@youribonnaffe

I was going over the codebase to learn about the project and noticed (and rather Copilot...) that in

the call to runStepInternal was not using the options properly.

Here is the output from Copilot:

In runStepInternal(ThrowingSupplier<T,E> stepfunc, StepOptions opts, ...) the call forwards options as:
runStepInternal(opts.name(), opts.retriesAllowed(), opts.maxAttempts(), opts.backOffRate(), opts.intervalSeconds(), ...)
but the target method signature is String stepName, boolean retryAllowed, int maxAttempts, double timeBetweenAttemptsSec, double backOffRate, ...).
That means backOffRate and intervalSeconds are swapped when calling the retry loop — this will break retry timing/backoff behavior. This is a functional bug worth fixing.

The reasoning seems correct. Considering the fix looks easy enough, I'm opening a PR for it.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions