Skip to content

Commit a10130b

Browse files
author
d3fault
committed
add clarification of what legal effect --signoff is supposed to even have
Fix: #106 Signed-off-by: d3fault <[email protected]>
1 parent 018d78c commit a10130b

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -168,9 +168,9 @@ module.exports = ({ app }) => {
168168
}
169169

170170
function handleOneCommit (pr, dcoFailed) {
171-
return `You only have one commit incorrectly signed off! To fix, first ensure you have a local copy of your branch by [checking out the pull request locally via command line](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/checking-out-pull-requests-locally). Next, head to your local branch and run: \n\`\`\`bash\ngit commit --amend --no-edit --signoff\n\`\`\`\nNow your commits will have your sign off. Next run \n\`\`\`bash\ngit push --force-with-lease origin ${pr.head.ref}\n\`\`\``
171+
return `You only have one commit incorrectly signed off! Signing off the commit certifies that the committer has the rights to submit this work under this project's license and agrees to the [Developer Certificate of Origin](https://developercertificate.org), either version 1.1 of the Developer Certificate of Origin, or (at your option) any later version. To fix, first ensure you have a local copy of your branch by [checking out the pull request locally via command line](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/checking-out-pull-requests-locally). Next, head to your local branch and run: \n\`\`\`bash\ngit commit --amend --no-edit --signoff\n\`\`\`\nNow your commits will have your sign off. Next run \n\`\`\`bash\ngit push --force-with-lease origin ${pr.head.ref}\n\`\`\``
172172
}
173173

174174
function handleMultipleCommits (pr, commitLength, dcoFailed) {
175-
return `You have ${dcoFailed.length} commits incorrectly signed off. To fix, first ensure you have a local copy of your branch by [checking out the pull request locally via command line](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/checking-out-pull-requests-locally). Next, head to your local branch and run: \n\`\`\`bash\ngit rebase HEAD~${commitLength} --signoff\n\`\`\`\n Now your commits will have your sign off. Next run \n\`\`\`bash\ngit push --force-with-lease origin ${pr.head.ref}\n\`\`\``
175+
return `You have ${dcoFailed.length} commits incorrectly signed off. Signing off the commit certifies that the committer has the rights to submit this work under this project's license and agrees to the [Developer Certificate of Origin](https://developercertificate.org), either version 1.1 of the Developer Certificate of Origin, or (at your option) any later version. To fix, first ensure you have a local copy of your branch by [checking out the pull request locally via command line](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/checking-out-pull-requests-locally). Next, head to your local branch and run: \n\`\`\`bash\ngit rebase HEAD~${commitLength} --signoff\n\`\`\`\n Now your commits will have your sign off. Next run \n\`\`\`bash\ngit push --force-with-lease origin ${pr.head.ref}\n\`\`\``
176176
}

0 commit comments

Comments
 (0)