Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Cosine Proximity Loss Function #29

Open
WuZhuoran opened this issue Jul 15, 2019 · 2 comments · May be fixed by #30
Open

Feature: Cosine Proximity Loss Function #29

WuZhuoran opened this issue Jul 15, 2019 · 2 comments · May be fixed by #30
Labels
enhancement New feature or request

Comments

@WuZhuoran
Copy link
Contributor

I try to implement the loss function, check the pull request for details.

  • Loss Function

Please check the comment of class.

  • Loss Function Grad

TODO.

  • Loss Function Test

Compare with scipy.cosine as gold.

  • Loss Function Grad Test

TODO.
@WuZhuoran WuZhuoran linked a pull request Jul 15, 2019 that will close this issue
Open
@ddbourgin ddbourgin added the enhancement New feature or request label Jul 16, 2019
@jeffin07
Copy link
Contributor

Is anybody working on this?

@ddbourgin
Copy link
Owner

@WuZhuoran began work on this, but it looks like it hasn't been touched in a while. At this stage the above PR would need to be rebased against master and the outstanding comments addressed. After that, it should be all set!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature add cosine proximity loss WuZhuoran/numpy-ml
3 participants
@ddbourgin @WuZhuoran @jeffin07