-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request: Use currency symbol instead of Convert icon when converting currency #67
Comments
I'm not sure I follow you. Do you mean the appropriate icon for each currency, or just one currency icon that's different from the normal icon? |
Right, that makes more sense than the other way. Do you know of a ready-made collection of currency icons? The workflow supports nearly 200 fiat currencies, and several times as many cryptocurrencies. There is no way I'm going to try and make even a fraction of those myself. I suppose flag icons would be an alternative, but I still don't fancy mapping hundreds of currencies to icons. |
I've found these for crypto: https://github.com/allienworks/cryptocoins | https://github.com/spothq/cryptocurrency-icons I can't seem to find currency symbols for fiat, but it might be more recognisable to use flags for that anyway. If neither of those crypto projects keep their icons in the same format as you'd need them, I might be able to help convert them if you give me a format / size to aim for 😄 |
Good finds. None of them are really in the right format/size, but that's easy enough to fix with a script. Workflow icons should be 128px (they're 64px in size, and double it for Retina screens). I still can't believe that fella called his workflow "Coon". Someone opened an issue explaining that the name is inapproriate, but I don't think he got across exactly how inappropriate it is. I'll have a think about it. The workflow itself has no idea what kind of units it's showing, so that would need to be handled, too. Perhaps I could add something generic, like "look for an icon named |
Yeah... That's one of the reasons I went looking for alternatives and found this project. Made sure to delete it off my computer as well.
Yeah, if there was a set of icons built-in, as well as a sub-folder in If I knew Python I'd dig around to see if I could help with a PR, my forte is PHP (pls no bully 😭) |
Exactly what I was thinking.
I'm going to create another issue to try to make clear that "culturally inappropriate" is a massive understatement. The author is Taiwanese, and I think he just didn't get how bad the word is. |
When converting currency into multiple units at once, it would make it easier to differentiate if a currency symbol was used instead of the Convert icon:
Thanks for considering :)
The text was updated successfully, but these errors were encountered: