fix(vm): fix errors with power state operations

Signed-off-by: dmitry.lopatin <dmitry.lopatin@flant.com>

Author: LopatinDmitr

images/virtualization-artifact/pkg/controller/powerstate/kvvm_request.go

@@ -17,14 +17,19 @@ limitations under the License.
 package powerstate
 
 import (
-	"fmt"
+	"errors"
 
 	"k8s.io/apimachinery/pkg/api/equality"
 	kvv1 "kubevirt.io/api/core/v1"
 
 	"github.com/deckhouse/virtualization-controller/pkg/common/patch"
 )
 
+var (
+	ErrChangesAlreadyExists    = errors.New("changes already exist in the current status")
+	ErrUnableToCompleteRequest = errors.New("unable to complete request: stop/start already underway")
+)
+
 // BuildPatch creates a patch to request VM state changing via updating KVVM status.
 //
 // Some combinations lead to an error to not interfere with kvvm controller:
@@ -49,8 +54,12 @@ func BuildPatch(vm *kvv1.VirtualMachine, changes ...kvv1.VirtualMachineStateChan
 			failOnConflict = false
 		}
 		if len(vm.Status.StateChangeRequests) != 0 {
+			if equality.Semantic.DeepEqual(vm.Status.StateChangeRequests, changes) {
+				return nil, ErrChangesAlreadyExists
+			}
+
 			if failOnConflict {
-				return nil, fmt.Errorf("unable to complete request: stop/start already underway")
+				return nil, ErrUnableToCompleteRequest
 			} else {
 				verb = patch.PatchReplaceOp
 			}

images/virtualization-artifact/pkg/controller/powerstate/operations.go

@@ -18,6 +18,7 @@ package powerstate
 
 import (
 	"context"
+	"errors"
 	"fmt"
 
 	"k8s.io/apimachinery/pkg/types"
@@ -36,6 +37,9 @@ func StartVM(ctx context.Context, cl client.Client, kvvm *kvv1.VirtualMachine) e
 	jp, err := BuildPatch(kvvm,
 		kvv1.VirtualMachineStateChangeRequest{Action: kvv1.StartRequest})
 	if err != nil {
+		if errors.Is(err, ErrChangesAlreadyExists) {
+			return nil
+		}
 		return err
 	}
 	return cl.Status().Patch(ctx, kvvm, client.RawPatch(types.JSONPatchType, jp), &client.SubResourcePatchOptions{})
@@ -70,6 +74,9 @@ func RestartVM(ctx context.Context, cl client.Client, kvvm *kvv1.VirtualMachine,
 		kvv1.VirtualMachineStateChangeRequest{Action: kvv1.StopRequest, UID: &kvvmi.UID},
 		kvv1.VirtualMachineStateChangeRequest{Action: kvv1.StartRequest})
 	if err != nil {
+		if errors.Is(err, ErrChangesAlreadyExists) {
+			return nil
+		}
 		return err
 	}
 

images/virtualization-artifact/pkg/controller/vm/internal/sync_power_state.go

@@ -70,6 +70,9 @@ func (h *SyncPowerStateHandler) Handle(ctx context.Context, s state.VirtualMachi
 	}
 
 	changed := s.VirtualMachine().Changed()
+	if isDeletion(changed) {
+		return reconcile.Result{}, nil
+	}
 
 	kvvm, err := s.KVVM(ctx)
 	if err != nil {