jsonrpc: Separate error handling for MaxBytesError#2605
Merged
jrick merged 3 commits intodecred:masterfrom Jan 28, 2026
Merged
Conversation
jrick
reviewed
Jan 9, 2026
internal/rpc/jsonrpc/server.go
Outdated
|
|
||
| body := http.MaxBytesReader(w, r.Body, maxRequestSize) | ||
| rpcRequest, err := io.ReadAll(body) | ||
| body.Close() |
Member
There was a problem hiding this comment.
This is not necessary. All the documentation for http.Request, both its Close field and the Body describe the server as always closing the request body automatically with no need to do this in the ServeHTTP handler.
jrick
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POST request handler would previously write
413 Request Too Largeregardless of error type, now it only does so when appropriate.Also a couple of other minor improvements/fixes.