feat: adding updated/delete by filter + tests to AzureAISearchDocument Store
#2586
+223
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
integration:azure-ai-search
type:documentation
davidsbatista
changed the title
AzureusAISearch Document Store
davidsbatista
removed
the
type:documentation
anakin87
reviewed
Dec 9, 2025
.../azure_ai_search/src/haystack_integrations/document_stores/azure_ai_search/document_store.py
Outdated
Show resolved
Hide resolved
.../azure_ai_search/src/haystack_integrations/document_stores/azure_ai_search/document_store.py
Outdated
Show resolved
Hide resolved
.../azure_ai_search/src/haystack_integrations/document_stores/azure_ai_search/document_store.py
Outdated
Show resolved
Hide resolved
.../azure_ai_search/src/haystack_integrations/document_stores/azure_ai_search/document_store.py
Outdated
Show resolved
Hide resolved
github-actions
bot
added
the
type:documentation
anakin87
reviewed
Dec 10, 2025
.../azure_ai_search/src/haystack_integrations/document_stores/azure_ai_search/document_store.py
Outdated
Show resolved
Hide resolved
.../azure_ai_search/src/haystack_integrations/document_stores/azure_ai_search/document_store.py
Outdated
Show resolved
Hide resolved
anakin87
changed the title
AzureusAISearch Document StoreAzureAISearchDocument Store
…t_stores/azure_ai_search/document_store.py Co-authored-by: Stefano Fiorucci <[email protected]>
Contributor
Author
|
@anakin87 - I think is totally fine to remove this patch - the init doesn't allocate any resources or establish any connection. It's just testing that the parameters are held/stored on the object instance. |
Member
|
@davidsbatista sorry I now tried and I agree. Sorry |
anakin87
approved these changes
Dec 10, 2025
Member
anakin87
left a comment
anakin87
left a comment
There was a problem hiding this comment.
Remove that patch and feel free to merge
davidsbatista
deleted the
fix/delete-update-by-filter-azureus-doc-store
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
update_by_filter()anddelete_by_filter()operations toAzureAISearchDocumentStore#2328Proposed Changes:
delete_by_filter()method to delete documents matching filter criteriaupdate_by_filter()method to update fields of documents matching filter criteria_normalize_metadata_index_fieldsa static method (it doesn't need instance state)@patchdecorator fromtest_initin Azure AI Search tests that caused the test to use a MagicMock instead of a real instanceHow did you test it?
delete_by_filterandupdate_by_filter(5 new test cases)Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.