allow seperate learning rate "muon_lr" and "adam_lr" for muon optimizer #7658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guokai Ma <[email protected]>
PKUWZP
approved these changes
Oct 30, 2025
| if muon_params: | ||
| accepted_parameters = dict() | ||
| for key in ["lr", "momentum", "weight_decay"]: | ||
| for key in ["lr", "momentum", "weight_decay", "muon_lr"]: |
Collaborator
There was a problem hiding this comment.
Does the user need to specific "muon_lr" for their training jobs?
Collaborator
Author
There was a problem hiding this comment.
Not mandatory, 'lr' will apply to both muon and adam. However, 'muon_lr' will be used if present. Same for 'adam_lr'. Thinking them as advanced user setting.
Collaborator
Author
loadams
approved these changes
Nov 5, 2025
LckyLke
pushed a commit
to LckyLke/DeepSpeed
that referenced
this pull request
Nov 11, 2025
…er (deepspeedai#7658) This PR allows seperate learning rate for muon and adam part of the Muon optimizer. Following up deepspeedai#7657 Signed-off-by: Guokai Ma <[email protected]> Co-authored-by: Olatunji Ruwase <[email protected]> Signed-off-by: Luke Friedrichs <[email protected]>
LckyLke
pushed a commit
to LckyLke/DeepSpeed
that referenced
this pull request
Nov 11, 2025
…er (deepspeedai#7658) This PR allows seperate learning rate for muon and adam part of the Muon optimizer. Following up deepspeedai#7657 Signed-off-by: Guokai Ma <[email protected]> Co-authored-by: Olatunji Ruwase <[email protected]> Signed-off-by: Luke Friedrichs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows seperate learning rate for muon and adam part of the Muon optimizer. Following up #7657