Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cookie method name is kind of inconsistent #38

Open
guiyumin opened this issue Sep 20, 2024 · 0 comments
Open

cookie method name is kind of inconsistent #38

guiyumin opened this issue Sep 20, 2024 · 0 comments

Comments

@guiyumin
Copy link

hi, thank you for the good library.

i see there is Delight\Cookie\Session::set , while the similar method in cookie is Delight\Cookie\Cookie::setcookie

do you think we can re-name it Delight\Cookie\Cookie::set to make them consistent ?

Thanks.
@guiyumin guiyumin changed the title cookie method name is kind of not proper cookie method name is kind of inconsistent Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@guiyumin