Merge pull request #13 from delphi-hub/bugfix/fix-return-code

24santoshr · web-flow · commit d679ee92f0fb · 2018-09-12T11:46:41.000+02:00
When no matching instance is found the registry now returns 404
diff --git a/src/main/scala/de/upb/cs/swt/delphi/instanceregistry/Server.scala b/src/main/scala/de/upb/cs/swt/delphi/instanceregistry/Server.scala
@@ -111,7 +111,7 @@ object Server extends HttpApp with JsonSupport with AppLogging {
       val matchingInstances = instances filter {instance => instance.componentType == compType}
       if(matchingInstances.isEmpty){
         log.warning(s"Could not find matching instance for type $compType .")
-        complete(HttpResponse(StatusCodes.BadRequest, entity = s"Could not find matching instance for type $compType"))
+        complete(HttpResponse(StatusCodes.NotFound, entity = s"Could not find matching instance for type $compType"))
       }
       else {
         val matchedInstance = matchingInstances.iterator.next()

Original file line number	Diff line number	Diff line change
`@@ -111,7 +111,7 @@ object Server extends HttpApp with JsonSupport with AppLogging {`
`111`	`111`	`val matchingInstances = instances filter {instance => instance.componentType == compType}`
`112`	`112`	`if(matchingInstances.isEmpty){`
`113`	`113`	`log.warning(s"Could not find matching instance for type $compType .")`
`114`		`- complete(HttpResponse(StatusCodes.BadRequest, entity = s"Could not find matching instance for type $compType"))`
	`114`	`+ complete(HttpResponse(StatusCodes.NotFound, entity = s"Could not find matching instance for type $compType"))`
`115`	`115`	`}`
`116`	`116`	`else {`
`117`	`117`	`val matchedInstance = matchingInstances.iterator.next()`