Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In FFI, don't panic if visit_scan_files returns an error #680

Open
nicklan opened this issue Feb 6, 2025 · 0 comments
Open

In FFI, don't panic if visit_scan_files returns an error #680

nicklan opened this issue Feb 6, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@nicklan
Copy link
Collaborator

nicklan commented Feb 6, 2025

This isn't actually quite as easy at it seems. To become an ExternResult you need an engine, and as the APIs are now you likely won't have an engine when calling this, because kernel_scan_data_next doesn't have one, so it can't pass it in when it calls this function.

We could take an engine arg in kernel_scan_data_next and thread it all the way through. This might be the right thing to do. We could also just require an engine in visit_scan_data and trust that engines can either shove it in the context or have global access to an engine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant