You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The model for Engine -> kernel expression visiting is different from Kernel -> Engine visitor.
In particular, visit_expression_and is not great to implement over ffi due to the EngineIterator. It would be easier to use the child list abstraction that schema visitor and kernel->engine visitor use.
Moreover, it is not intuitive that the *const c_void child is casted to a usize in this:
Please describe why this is necessary.
The model for Engine -> kernel expression visiting is different from Kernel -> Engine visitor.
In particular,
visit_expression_and
is not great to implement over ffi due to the EngineIterator. It would be easier to use the child list abstraction that schema visitor and kernel->engine visitor use.Moreover, it is not intuitive that the
*const c_void
child is casted to ausize
in this:Describe the functionality you are proposing.
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: