Skip to content

Commit 66133b5

Browse files
authored
Fix negative number parsing in fixed-point-wasm (#1469)
* Fix sign removal in `Numberish` parsing. * Rebuild crate * Add changeset
1 parent 1b49268 commit 66133b5

File tree

3 files changed

+8
-3
lines changed

3 files changed

+8
-3
lines changed
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@delvtech/fixed-point-wasm": patch
3+
---
4+
5+
Fix negative number parsing for strings and `parseFixed`

crates/fixed-point-wasm/src/lib.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -452,11 +452,11 @@ impl TryFrom<Numberish> for FixedPoint<I256> {
452452
.replace_all(",", "");
453453
let mut sign = 1;
454454
if s.starts_with("-", 0) {
455-
s = s.slice(0, s.length());
455+
s = s.slice(1, s.length());
456456
sign = -1;
457457
};
458458
if s.starts_with("+", 0) {
459-
s = s.slice(0, s.length());
459+
s = s.slice(1, s.length());
460460
};
461461
if s.starts_with("0x", 0) || s.starts_with("0b", 0) || s.starts_with("0o", 0) {
462462
let int = s.to_i256()? * I256::from(sign);

packages/fixed-point-wasm/fixed_point_wasm.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)