Fix error in modal closing behavior (#1475)

* Don't assume modal exists when calling .close()

* Update tooltips

Author: DannyDelott

apps/hyperdrive-trading/src/ui/hyperdrive/longs/CloseLongForm/CloseLongForm.tsx

@@ -125,7 +125,9 @@ export function CloseLongForm({
     asBase: activeWithdrawToken.address === hyperdrive.poolConfig.baseToken,
     enabled: previewCloseLongStatus === "success",
     onSubmitted: () => {
-      (document.getElementById(`${long.assetId}`) as HTMLDialogElement).close();
+      (
+        document.getElementById(`${long.assetId}`) as HTMLDialogElement
+      )?.close();
     },
     onExecuted: () => {
       setAmount("");

apps/hyperdrive-trading/src/ui/hyperdrive/longs/OpenLongForm/OpenLongForm.tsx

@@ -186,7 +186,7 @@ export function OpenLongForm({
     destination: account,
     enabled: openLongPreviewStatus === "success" && hasEnoughAllowance,
     onSubmitted: () => {
-      (document.getElementById("open-long") as HTMLDialogElement).close();
+      (document.getElementById("open-long") as HTMLDialogElement)?.close();
     },
     onExecuted: () => {
       setAmount("");

apps/hyperdrive-trading/src/ui/hyperdrive/longs/OpenLongForm/OpenLongForm2.tsx

@@ -183,7 +183,7 @@ export function OpenLongForm2({
     destination: account,
     enabled: openLongPreviewStatus === "success" && hasEnoughAllowance,
     onSubmitted: () => {
-      (document.getElementById("open-long") as HTMLDialogElement).close();
+      (document.getElementById("open-long") as HTMLDialogElement)?.close();
     },
     onExecuted: () => {
       setAmount("");

apps/hyperdrive-trading/src/ui/hyperdrive/longs/OpenLongModalButton/OpenLongModalButton.tsx

@@ -24,7 +24,7 @@ export function OpenLongModalButton({
 
   function closeModal() {
     // eslint-disable-next-line @typescript-eslint/no-explicit-any
-    (window as any)[modalId].close();
+    (window as any)[modalId]?.close();
   }
 
   if (marketState?.isPaused) {

apps/hyperdrive-trading/src/ui/hyperdrive/lp/AddLiquidityForm/AddLiquidityForm.tsx

@@ -243,7 +243,7 @@ export function AddLiquidityForm({
       addLiquidityPreviewStatus === "success",
     onSubmitted: () => {
       // eslint-disable-next-line @typescript-eslint/no-explicit-any
-      (window as any)["add-lp"].close();
+      (window as any)["add-lp"]?.close();
     },
     onExecuted: () => {
       setAmount("");

apps/hyperdrive-trading/src/ui/hyperdrive/lp/AddLiquidityForm/AddLiquidityForm2.tsx

@@ -241,7 +241,7 @@ export function AddLiquidityForm2({
       addLiquidityPreviewStatus === "success",
     onSubmitted: () => {
       // eslint-disable-next-line @typescript-eslint/no-explicit-any
-      (window as any)["add-lp"].close();
+      (window as any)["add-lp"]?.close();
     },
     onExecuted: () => {
       setAmount("");

apps/hyperdrive-trading/src/ui/hyperdrive/lp/OpenLpSharesCard/OpenLpSharesCard.tsx

@@ -227,7 +227,7 @@ export function OpenLpSharesCard({
                       className="daisy-btn daisy-btn-circle daisy-btn-ghost daisy-btn-sm absolute right-4 top-4"
                       onClick={() =>
                         // eslint-disable-next-line @typescript-eslint/no-explicit-any
-                        (window as any)["withdrawalLpModal"].close()
+                        (window as any)["withdrawalLpModal"]?.close()
                       }
                     >
                       <XMarkIcon className="w-6" title="Close" />

apps/hyperdrive-trading/src/ui/hyperdrive/lp/RemoveLiquidityForm/RemoveLiquidityForm.tsx

@@ -157,7 +157,7 @@ export function RemoveLiquidityForm({
       activeWithdrawToken.address === baseToken.address,
     onSubmitted: () => {
       // eslint-disable-next-line @typescript-eslint/no-explicit-any
-      (window as any)["withdrawalLpModal"].close();
+      (window as any)["withdrawalLpModal"]?.close();
     },
     onExecuted: () => {
       setAmount("");

apps/hyperdrive-trading/src/ui/hyperdrive/shorts/CloseShortForm/CloseShortForm.tsx

@@ -110,7 +110,7 @@ export function CloseShortForm({
       hyperdrive.withdrawOptions.isBaseTokenWithdrawalEnabled &&
       activeWithdrawToken.address === hyperdrive.poolConfig.baseToken,
     onSubmitted: (hash) => {
-      (window as any)[`${short.assetId}`].close();
+      (window as any)[`${short.assetId}`]?.close();
     },
     onExecuted: (hash) => {
       setAmount("");

apps/hyperdrive-trading/src/ui/hyperdrive/shorts/CloseShortModalButton/CloseShortModalButton.tsx

@@ -44,7 +44,7 @@ export function CloseShortModalButton({
   const maturityMilliseconds = Number(short.maturity * 1000n);
   const isMature = Date.now() > maturityMilliseconds;
   function closeModal() {
-    (window as any)[modalId].close();
+    (window as any)[modalId]?.close();
   }
 
   return (