Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tag 1.14.2 using deno 1.14.1 #182

Open
treethought opened this issue Oct 1, 2021 · 1 comment
Open

tag 1.14.2 using deno 1.14.1 #182

treethought opened this issue Oct 1, 2021 · 1 comment

Comments

@treethought
Copy link

local deno CLI - confirms deno release displays correct version

➜ deno --version
deno 1.14.2 (release, x86_64-unknown-linux-gnu)
v8 9.4.146.16
typescript 4.4.2

deno docker image

➜ docker run -it denoland/deno:1.14.2 --version
Unable to find image 'denoland/deno:1.14.2' locally
1.14.2: Pulling from denoland/deno
af5aff8d4565: Pull complete
0f2cf4000653: Pull complete
095fb02c802a: Pull complete
042576a28d36: Pull complete
7cc1a90286f0: Pull complete
28696a5886e6: Pull complete
Digest: sha256:8967319326cba27ac33be2e7d23256ca6567be79e8f5ac215c3339d5f4438e90
Status: Downloaded newer image for denoland/deno:1.14.2
deno 1.14.1 (release, x86_64-unknown-linux-gnu)
v8 9.4.146.15
typescript 4.4.2

@hayd
Copy link
Contributor

hayd commented Oct 2, 2021

I wonder if the version should be tested in the CI pipeline before tag/push:

docker tag ${{ matrix.kind }} denoland/deno:${{ matrix.kind }}-${GITHUB_REF#refs/*/}

Something like (not tested):

test ${GITHUB_REF#refs/*/} = ${docker run -t ${{ matrix.kind }} --version | grep deno | cut -d ' ' -f2}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants